Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix catalog test for ppc64le #1255

Merged
merged 1 commit into from
May 31, 2024
Merged

Fix catalog test for ppc64le #1255

merged 1 commit into from
May 31, 2024

Conversation

Sachin-Itagi
Copy link
Contributor

Changes

Replaces the GRADLE_IMAGE parameter for gradle/0.4 to the multi-arch alternative. Currently the image is x86 only.

Added an Extra MAVEN_IMAGE parameter which is missing for the maven-0-3 test via linux-ppc64le.sh script.

Added a patch command to enable Step Actions on the cluster. This is needed for stepaction test.

Added a patch command to disable Affinity Assistant on the cluster. This allow binding of two PVCs at the same time and is needed by the maven-0-3 test.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Follows the authoring recommendations
  • Includes docs (if user facing)
  • Includes tests (for new tasks or changed functionality)
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Commit messages follow commit message best practices
  • Has a kind label. You can add one by adding a comment on this PR that
    contains /kind <type>. Valid types are bug, cleanup, design, documentation,
    feature, flake, misc, question, tep
  • Complies with Catalog Organization TEP, see example. Note An issue has been filed to automate this validation

    • File path follows <kind>/<name>/<version>/name.yaml

    • Has README.md at <kind>/<name>/<version>/README.md

    • Has mandatory metadata.labels - app.kubernetes.io/version the same as the <version> of the resource

    • Has mandatory metadata.annotations tekton.dev/pipelines.minVersion

    • mandatory spec.description follows the convention

        ```

  spec:
    description: >-
      one line summary of the resource

      Paragraph(s) to describe the resource.
  ```

See the contribution guide for more details.

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented May 3, 2024 •
edited

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: Sachin-Itagi / name: Sachin Itagi (144de9f)

@tekton-robot tekton-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 3, 2024
@tekton-robot
Copy link

Hi @Sachin-Itagi. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 3, 2024
@Sachin-Itagi
Copy link
Contributor Author

@vdemeester @bobcatfish Can you please review this PR which fixes the catalog test for Power.

@AlanGreene
Copy link
Member

Should this bump the task version to 0.5?

@valen-mascarenhas14
Copy link

@afrittoli could you please review this PR ?

vinamra28
vinamra28 approved these changes May 10, 2024
View reviewed changes
Copy link
Member

@vinamra28 vinamra28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/ok-to-test

@tekton-robot tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 10, 2024
@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vinamra28

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 10, 2024
@Sachin-Itagi
Copy link
Contributor Author

/test pull-tekton-catalog-integration-tests

3 similar comments
@Sachin-Itagi
Copy link
Contributor Author

/test pull-tekton-catalog-integration-tests

@Sachin-Itagi
Copy link
Contributor Author

/test pull-tekton-catalog-integration-tests

@Sachin-Itagi
Copy link
Contributor Author

/test pull-tekton-catalog-integration-tests

@tekton-robot tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label May 14, 2024
@vdemeester
Copy link
Member

/retest

@Sachin-Itagi Sachin-Itagi force-pushed the fixCatalogTestPower branch 2 times, most recently from 0804cd6 to 2734c66 Compare May 21, 2024 09:43
@Sachin-Itagi
Copy link
Contributor Author

/test pull-tekton-catalog-integration-tests

@Sachin-Itagi
Copy link
Contributor Author

@vinamra28 @vdemeester Any suggestions on resolving the failure observed during the pull-tekton-catalog-integration-tests Job. The changes that have been made don't seem to be the cause of this issue and It doesn't seem to be a flaky issue as well.

It seems to be an issue with PIP.
Could not fetch URL https://pypi.python.org/simple/pip/: There was a problem confirming the ssl certificate: [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed (_ssl.c:852) - skipping

Any help to resolve this issue and merge the PR would be appreciated. Thanks.

@vinamra28
Copy link
Member

@Sachin-Itagi, this task should get fixed in #1266

@Sachin-Itagi
Fix catalog test for ppc64le
144de9f 
Replace gradle image for gradle-0-4 test.
Add patch command to fix stepaction test.
Add Extra MAVEN_IMAGE parameter and patch command for maven-0-3 test.

Signed-off-by: Sachin Itagi <[email protected]>
@Sachin-Itagi
Copy link
Contributor Author

/test pull-tekton-catalog-integration-tests

@vinamra28
Copy link
Member

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label May 31, 2024
@tekton-robot tekton-robot merged commit 6fe5338 into tektoncd:main May 31, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinamra28 vinamra28 vinamra28 approved these changes

@bobcatfish bobcatfish Awaiting requested review from bobcatfish

@vdemeester vdemeester Awaiting requested review from vdemeester

Assignees

@vinamra28 vinamra28

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Sachin-Itagi @tekton-robot @AlanGreene @valen-mascarenhas14 @vdemeester @vinamra28