Update default helm image for helm-upgrade-from- tasks #1252

mikecroft · 2024-04-24T13:57:04Z

Changes

This PR updates the default image used in the helm-upgrade-from-repo and helm-upgrade-from-source tasks from v3.6.0 to v3.10.2.

The main motivation for this change is that the existing version does not include the --dependency-upgrade option. This change therefore provides the ability for charts to not package their dependencies.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

Follows the authoring recommendations
Includes docs (if user facing)
Includes tests (for new tasks or changed functionality)
- See the end-to-end testing documentation for guidance and CI details.
Meets the Tekton contributor standards (including functionality, content, code)
Commit messages follow commit message best practices
Has a kind label. You can add one by adding a comment on this PR that
contains /kind <type>. Valid types are bug, cleanup, design, documentation,
feature, flake, misc, question, tep
Complies with Catalog Organization TEP, see example. Note An issue has been filed to automate this validation
- File path follows <kind>/<name>/<version>/name.yaml
- Has README.md at <kind>/<name>/<version>/README.md
- Has mandatory metadata.labels - app.kubernetes.io/version the same as the <version> of the resource
- Has mandatory metadata.annotations tekton.dev/pipelines.minVersion
- mandatory spec.description follows the convention
```
  ```
  
    spec:
      description: >-
        one line summary of the resource
  
        Paragraph(s) to describe the resource.
  ```
```

See the contribution guide for more details.

…m-source from 0.3 to 0.4

linux-foundation-easycla · 2024-04-24T13:57:11Z

The committers listed above are authorized under a signed CLA.

✅ login: mikecroft / name: Mike Croft (495955c, c86b0fb, 6c3b64e)

tekton-robot · 2024-04-24T13:57:14Z

Hi @mikecroft. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tekton-robot · 2024-04-24T13:57:59Z

Catlin Output

FILE: task/helm-upgrade-from-repo/0.3/helm-upgrade-from-repo.yaml
ERROR: Resource path is invalid; expected path: task/helm-upgrade-from-repo/0.2/helm-upgrade-from-repo.yaml
HINT : Task: tekton.dev/v1beta1 - name: "helm-upgrade-from-repo" is missing a readable display name annotation("tekton.dev/displayName")
WARN : Step "upgrade-from-repo" uses image "$(params.helm_image)" that contains variables; skipping validation

Catlin script lint Output

ERROR: /usr/bin/shellcheck, [-s sh] failed:

In helm-upgrade-from-repo-upgrade-from-repo line 5:
REPO=`echo "$(params.chart_name)" | cut -d "/" -f 1`
     ^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`.
           ^--------------------^ SC2005 (style): Useless echo? Instead of 'echo $(cmd)', just use 'cmd'.

Did you mean: 
REPO=$(echo "$(params.chart_name)" | cut -d "/" -f 1)


In helm-upgrade-from-repo-upgrade-from-repo line 7:
helm repo add $REPO "$(params.helm_repo)"
              ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
helm repo add "$REPO" "$(params.helm_repo)"


In helm-upgrade-from-repo-upgrade-from-repo line 11:
helm upgrade --wait --install --namespace "$(params.release_namespace)" $(params.release_name) $(params.chart_name) --debug --set "$(params.overwrite_values)"
                                                                        ^--------------------^ SC2046 (warning): Quote this to prevent word splitting.
                                                                                               ^------------------^ SC2046 (warning): Quote this to prevent word splitting.

For more information:
  https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...
  https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...
  https://www.shellcheck.net/wiki/SC2005 -- Useless echo? Instead of 'echo $(...

ERROR: /usr/bin/shellcheck, [-s sh] failed:

In helm-upgrade-from-source-upgrade line 6:
helm upgrade --install --wait --values "$(params.charts_dir)/$(params.values_file)" --namespace "$(params.release_namespace)" --version "$(params.release_version)" "$(params.release_name)" "$(params.charts_dir)" --debug --set "$(params.overwrite_values)" $(params.upgrade_extra_params)
                                                                                                                                                                                                                                                               ^----------------------------^ SC2046 (warning): Quote this to prevent word splitting.

For more information:
  https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...

task/helm-upgrade-from-repo/0.3/helm-upgrade-from-repo.yaml

task/helm-upgrade-from-repo/0.3/README.md

fhopfensperger · 2024-05-03T19:59:25Z

/ok-to-test

task/helm-upgrade-from-source/0.4/helm-upgrade-from-source.yaml

Updates version number labels to match files Co-authored-by: Florian Hopfensperger <[email protected]>

tekton-robot · 2024-05-04T09:46:51Z

Catlin Output

FILE: task/helm-upgrade-from-repo/0.3/helm-upgrade-from-repo.yaml
HINT : Task: tekton.dev/v1beta1 - name: "helm-upgrade-from-repo" is missing a readable display name annotation("tekton.dev/displayName")
WARN : Step "upgrade-from-repo" uses image "$(params.helm_image)" that contains variables; skipping validation
FILE: task/helm-upgrade-from-source/0.4/helm-upgrade-from-source.yaml
HINT : Task: tekton.dev/v1beta1 - name: "helm-upgrade-from-source" is missing a readable display name annotation("tekton.dev/displayName")
WARN : Step "upgrade" uses image "$(params.helm_image)" that contains variables; skipping validation

Catlin script lint Output

ERROR: /usr/bin/shellcheck, [-s sh] failed:

In helm-upgrade-from-repo-upgrade-from-repo line 5:
REPO=`echo "$(params.chart_name)" | cut -d "/" -f 1`
     ^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`.
           ^--------------------^ SC2005 (style): Useless echo? Instead of 'echo $(cmd)', just use 'cmd'.

Did you mean: 
REPO=$(echo "$(params.chart_name)" | cut -d "/" -f 1)


In helm-upgrade-from-repo-upgrade-from-repo line 7:
helm repo add $REPO "$(params.helm_repo)"
              ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
helm repo add "$REPO" "$(params.helm_repo)"


In helm-upgrade-from-repo-upgrade-from-repo line 11:
helm upgrade --wait --install --namespace "$(params.release_namespace)" $(params.release_name) $(params.chart_name) --debug --set "$(params.overwrite_values)"
                                                                        ^--------------------^ SC2046 (warning): Quote this to prevent word splitting.
                                                                                               ^------------------^ SC2046 (warning): Quote this to prevent word splitting.

For more information:
  https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...
  https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...
  https://www.shellcheck.net/wiki/SC2005 -- Useless echo? Instead of 'echo $(...

ERROR: /usr/bin/shellcheck, [-s sh] failed:

In helm-upgrade-from-source-upgrade line 6:
helm upgrade --install --wait --values "$(params.charts_dir)/$(params.values_file)" --namespace "$(params.release_namespace)" --version "$(params.release_version)" "$(params.release_name)" "$(params.charts_dir)" --debug --set "$(params.overwrite_values)" $(params.upgrade_extra_params)
                                                                                                                                                                                                                                                               ^----------------------------^ SC2046 (warning): Quote this to prevent word splitting.

For more information:
  https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...

vinamra28 · 2024-05-13T05:19:30Z

/test pull-catalog-catlin-lint

tekton-robot · 2024-05-13T05:19:33Z

@vinamra28: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test pull-tekton-catalog-build-tests
/test pull-tekton-catalog-integration-tests
/test pull-tekton-catalog-unit-tests

Use /test all to run all jobs.

In response to this:

/test pull-catalog-catlin-lint

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tekton-robot · 2024-05-13T05:20:21Z

Catlin Output

FILE: task/helm-upgrade-from-repo/0.3/helm-upgrade-from-repo.yaml
HINT : Task: tekton.dev/v1beta1 - name: "helm-upgrade-from-repo" is missing a readable display name annotation("tekton.dev/displayName")
WARN : Step "upgrade-from-repo" uses image "$(params.helm_image)" that contains variables; skipping validation
FILE: task/helm-upgrade-from-source/0.4/helm-upgrade-from-source.yaml
HINT : Task: tekton.dev/v1beta1 - name: "helm-upgrade-from-source" is missing a readable display name annotation("tekton.dev/displayName")
WARN : Step "upgrade" uses image "$(params.helm_image)" that contains variables; skipping validation

Catlin script lint Output

ERROR: /usr/bin/shellcheck, [-s sh] failed:

In helm-upgrade-from-repo-upgrade-from-repo line 5:
REPO=`echo "$(params.chart_name)" | cut -d "/" -f 1`
     ^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`.
           ^--------------------^ SC2005 (style): Useless echo? Instead of 'echo $(cmd)', just use 'cmd'.

Did you mean: 
REPO=$(echo "$(params.chart_name)" | cut -d "/" -f 1)


In helm-upgrade-from-repo-upgrade-from-repo line 7:
helm repo add $REPO "$(params.helm_repo)"
              ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
helm repo add "$REPO" "$(params.helm_repo)"


In helm-upgrade-from-repo-upgrade-from-repo line 11:
helm upgrade --wait --install --namespace "$(params.release_namespace)" $(params.release_name) $(params.chart_name) --debug --set "$(params.overwrite_values)"
                                                                        ^--------------------^ SC2046 (warning): Quote this to prevent word splitting.
                                                                                               ^------------------^ SC2046 (warning): Quote this to prevent word splitting.

For more information:
  https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...
  https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...
  https://www.shellcheck.net/wiki/SC2005 -- Useless echo? Instead of 'echo $(...

ERROR: /usr/bin/shellcheck, [-s sh] failed:

In helm-upgrade-from-source-upgrade line 6:
helm upgrade --install --wait --values "$(params.charts_dir)/$(params.values_file)" --namespace "$(params.release_namespace)" --version "$(params.release_version)" "$(params.release_name)" "$(params.charts_dir)" --debug --set "$(params.overwrite_values)" $(params.upgrade_extra_params)
                                                                                                                                                                                                                                                               ^----------------------------^ SC2046 (warning): Quote this to prevent word splitting.

For more information:
  https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...

mikecroft · 2024-05-20T10:01:34Z

Is there anything else I need to do to get this merged? It looks like it only needs approval, but I'm happy to add more changes if needed.

fhopfensperger · 2024-05-20T11:00:56Z

Thank you very much for the PR.
I was off the last weeks.
/lgtm

tekton-robot · 2024-05-27T04:19:49Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vinamra28

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~task/helm-upgrade-from-repo/OWNERS~~ [vinamra28]
~~task/helm-upgrade-from-source/OWNERS~~ [vinamra28]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

mikecroft added 2 commits April 24, 2024 14:17

copy task helm-upgrade-from-repo from 0.2 to 0.3 and helm-upgrade-fro…

495955c

…m-source from 0.3 to 0.4

update default Helm image from 3.6 to 3.10.2

c86b0fb

tekton-robot requested review from bobcatfish and fhopfensperger April 24, 2024 13:57

tekton-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 24, 2024

tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 24, 2024

mikecroft changed the title ~~Update helm image~~ Update default helm image for helm-upgrade-from- tasks Apr 24, 2024

fhopfensperger reviewed May 3, 2024

View reviewed changes

task/helm-upgrade-from-repo/0.3/helm-upgrade-from-repo.yaml Outdated Show resolved Hide resolved

fhopfensperger reviewed May 3, 2024

View reviewed changes

task/helm-upgrade-from-repo/0.3/README.md Outdated Show resolved Hide resolved

tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 3, 2024

fhopfensperger reviewed May 3, 2024

View reviewed changes

task/helm-upgrade-from-source/0.4/helm-upgrade-from-source.yaml Outdated Show resolved Hide resolved

Apply suggestions from code review

6c3b64e

Updates version number labels to match files Co-authored-by: Florian Hopfensperger <[email protected]>

tekton-robot assigned fhopfensperger May 20, 2024

tekton-robot added the lgtm Indicates that a PR is ready to be merged. label May 20, 2024

vinamra28 approved these changes May 27, 2024

View reviewed changes

tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 27, 2024

tekton-robot merged commit c76eaf1 into tektoncd:main May 27, 2024
6 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update default helm image for helm-upgrade-from- tasks #1252

Update default helm image for helm-upgrade-from- tasks #1252

mikecroft commented Apr 24, 2024

linux-foundation-easycla bot commented Apr 24, 2024 •

edited

tekton-robot commented Apr 24, 2024

tekton-robot commented Apr 24, 2024

fhopfensperger commented May 3, 2024

tekton-robot commented May 4, 2024

vinamra28 commented May 13, 2024

tekton-robot commented May 13, 2024

tekton-robot commented May 13, 2024

mikecroft commented May 20, 2024

fhopfensperger commented May 20, 2024

tekton-robot commented May 27, 2024

Update default helm image for helm-upgrade-from- tasks #1252

Update default helm image for helm-upgrade-from- tasks #1252

Conversation

mikecroft commented Apr 24, 2024

Changes

Submitter Checklist

linux-foundation-easycla bot commented Apr 24, 2024 • edited

tekton-robot commented Apr 24, 2024

tekton-robot commented Apr 24, 2024

fhopfensperger commented May 3, 2024

tekton-robot commented May 4, 2024

vinamra28 commented May 13, 2024

tekton-robot commented May 13, 2024

tekton-robot commented May 13, 2024

mikecroft commented May 20, 2024

fhopfensperger commented May 20, 2024

tekton-robot commented May 27, 2024

linux-foundation-easycla bot commented Apr 24, 2024 •

edited