Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added jira-get-ticket-status new task #1251

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Added jira-get-ticket-status new task #1251

wants to merge 5 commits into from

Conversation

jlozano-rh
Copy link

Changes

Added a new task jira-get-ticket-status to get the current status of a Jira ticket.

@tekton-robot tekton-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 16, 2024
@tekton-robot
Copy link

Hi @jlozano-rh. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 16, 2024
@tekton-robot
Copy link

Catlin Output 
FILE: task/jira-get-ticket-status/0.1/jira-get-ticket-status.yaml
ERROR: Step "get-ticket-status" uses image "registry.access.redhat.com/ubi8/python-39" which must be tagged with a specific version
WARN : Step "get-ticket-status" uses secret as environment variables. Prefer using secrets as files over secrets as environment variables

@jlozano-rh
Copy link
Author

/assign @vinamra28

@jlozano-rh
Update jira-get-ticket-status.yaml
b94f244 
Add SHA instead of tag named
@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please ask for approval from vinamra28 after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot
Copy link

Catlin Output 
FILE: task/jira-get-ticket-status/0.1/jira-get-ticket-status.yaml
WARN : Step "get-ticket-status" uses image "registry.access.redhat.com/ubi8/python-39@sha256:27e795fd6b1b77de70d1dc73a65e4c790650748a9cfda138fdbd194b3d6eea3d"; consider using a image tagged with specific version along with digest eg. abc.io/img:v1@sha256:abcde

vinamra28
vinamra28 reviewed Apr 17, 2024
View reviewed changes
Copy link
Member

@vinamra28 vinamra28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @jlozano-rh for submitting the PR. Will it be possible to add some tests?
/ok-to-test

task/jira-get-ticket-status/0.1/jira-get-ticket-status.yaml Outdated
stepTemplate:
envFrom:
- secretRef:
name: jira-env-secret
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we try making this secret name as parameterized?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes! done

@tekton-robot tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 17, 2024
@tekton-robot
Copy link

Catlin Output 
FILE: task/jira-get-ticket-status/0.1/jira-get-ticket-status.yaml
WARN : Step "get-ticket-status" uses image "registry.access.redhat.com/ubi8/python-39@sha256:27e795fd6b1b77de70d1dc73a65e4c790650748a9cfda138fdbd194b3d6eea3d"; consider using a image tagged with specific version along with digest eg. abc.io/img:v1@sha256:abcde

@jlozano-rh
Copy link
Author

thanks @jlozano-rh for submitting the PR. Will it be possible to add some tests? /ok-to-test

I don't know, because we would have to have a jira platform available for testing. And also leave in the PR the credentials in the Secret object. This worries me, how did you solve this issue in other tasks?

@tekton-robot
Copy link

Catlin Output 
FILE: task/jira-get-ticket-status/0.1/jira-get-ticket-status.yaml
WARN : Step "get-ticket-status" uses image "registry.access.redhat.com/ubi8/python-39@sha256:27e795fd6b1b77de70d1dc73a65e4c790650748a9cfda138fdbd194b3d6eea3d"; consider using a image tagged with specific version along with digest eg. abc.io/img:v1@sha256:abcde

@tekton-robot
Copy link

@jlozano-rh: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-tekton-catalog-build-tests 98e934d link true /test pull-tekton-catalog-build-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@tekton-robot
Copy link

Catlin Output 
FILE: task/jira-get-ticket-status/0.1/jira-get-ticket-status.yaml
WARN : Step "get-ticket-status" uses image "registry.access.redhat.com/ubi8/python-39@sha256:27e795fd6b1b77de70d1dc73a65e4c790650748a9cfda138fdbd194b3d6eea3d"; consider using a image tagged with specific version along with digest eg. abc.io/img:v1@sha256:abcde

vinamra28
vinamra28 reviewed May 13, 2024
View reviewed changes
task/jira-get-ticket-status/0.1/jira-get-ticket-status.yaml
@@ -0,0 +1,81 @@
apiVersion: tekton.dev/v1beta1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we use latest apiVersion ? ie tekton.dev/v1

task/jira-get-ticket-status/0.1/jira-get-ticket-status.yaml
labels:
app.kubernetes.io/version: "0.1"
annotations:
tekton.dev/pipelines.minVersion: "0.12.1"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

latest version of pipelines is 0.59, since this is a new task, perhaps we can keep a near latest version for this.

@vinamra28
Copy link
Member

also the build test seems to be failing, can you please look at that as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinamra28 vinamra28 vinamra28 left review comments

@bobcatfish bobcatfish Awaiting requested review from bobcatfish

@vdemeester vdemeester Awaiting requested review from vdemeester

Assignees

@vinamra28 vinamra28

Labels
ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jlozano-rh @tekton-robot @vinamra28