Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabling CSRF is a security risk - and not needed #74

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Disabling CSRF is a security risk - and not needed #74

wants to merge 1 commit into from

Conversation

ashb
Copy link

@ashb ashb commented Jul 15, 2020

The RBAC UI for Airflow uses a different instance of the CSRF protection, so we need to import both decorators to be CSRF exempt when under RBAC UI.

Closes #73 and likely fixes #72 too

@kaxil
Copy link

kaxil commented Oct 6, 2020

cc @prakshalj0512 @rssanders3

@prakshalj0512
Copy link
Member

@kaxil Are these changes compatible with Airflow 1.8 and 1.9 as well?

@ashb
Copy link
Author

ashb commented Oct 7, 2020

Yes, the except ImportError block should take care of it

@ashb
Copy link
Author

ashb commented Apr 19, 2021

@prakshalj0512 Ping. Please can you either fix this security issue and release a new version, or mark this repo as abandoned and place a prominent notice at the top of the readme?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants