chore(graphql): upgrade graphql to v16 and apollo-server to v4 #8753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eer in the latest
…rom apollo-client. Create ws connection using graphql-ws
luvkapur
commented
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
graphqlandapollo-serverversion to the latest.One of the key update is dropping the dependency on
subscription-transport-wsto implement websockets and graphql subscriptions.subscription-transport-wsis not maintained and has numerous security issues. We replacesubscription-transport-wswith thegraphql-wswhich is the recommended lib to implement web sockets and graphql subscriptions.This PR also fixes subscriptions in the workspace. Previously, even though the schema had subscriptions defined for component updates in the workspace, it wasn't implemented correctly which resulted in the client never receiving any live updates from the server. With this fix, now the client receives live updates from the workspace regarding component updates (additions, modifications, deletions)
Workspace Live Updates
Apollo 4 Playground
