Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aspects loading fixes #6308

Draft
wants to merge 23 commits into
base: master
Choose a base branch
from
Draft

aspects loading fixes #6308

wants to merge 23 commits into from

Conversation

GiladShoham
Copy link
Member

@GiladShoham GiladShoham commented Aug 14, 2022 •
edited

Proposed Changes

  • do not add extension with empty data and config to the component extension list on load
  • add non core aspects with id rather than name when they only register data on load (and has no component's config)
  • do not add data to self on component load
  • improve legacy extension list find function
  • ignore version when upserting extension data

@GiladShoham
do not add extension with empty data and config to the component exte…
ed7540b 
…nsion list on load
@GiladShoham
add non core aspects with id rather than name when they only register…
e551b25 
… data on load (and has no component's config)
@GiladShoham
fix aspect id when aspect only register data on component load but no…
4d40913 
…t configured on the component
@GiladShoham
fix find extension - compare also with new extension id
a26cab7
@GiladShoham
increase test timeout
fc1e91d
@GiladShoham
Merge branch 'master' into aspects-loading-fixes
e8da91f
@GiladShoham
trying to increase timeouts in more places
cd3842e
@GiladShoham
remove wrong timeout
4d133ae
@GiladShoham
moving jest timeout to base config
fac069e
@GiladShoham
types
36995aa
@GiladShoham
increase timeout
b889cc9
@GiladShoham
tsignore for this.timeout in legacy tests to prevent conflicts betwee…
61dfbff 
…n jest and mocha when build legacy types
@GiladShoham
Merge branch 'master' into aspects-loading-fixes
570d19c
@GiladShoham
Merge branch 'master' into aspects-loading-fixes
3017a59
@GiladShoham
Merge branch 'master' into aspects-loading-fixes
4e914f4
@GiladShoham
do not add data to self on component load
d78d059
@GiladShoham
improve legacy extension list find function
5c41731
@GiladShoham
ignore version when upserting extension data
60ef1a4
@GiladShoham
Merge branch 'master' into aspects-loading-fixes
9c609c4
@GiladShoham
aspect get fixes
7d06e4b
@GiladShoham
Merge branch 'aspects-loading-fixes' of https://github.com/teambit/bit …
3759430 
…into aspects-loading-fixes
@GiladShoham
do save aspect data on aspect itself if it's a core aspect (to make s…
3b2d470 
…ure we have main prop in package.json of the pkg correctly)
@GiladShoham
Merge branch 'master' into aspects-loading-fixes
997915d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@GiladShoham