Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make library fully async #361

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sdb9696
Copy link
Collaborator

@sdb9696 sdb9696 commented Mar 26, 2024

No description provided.

Copy link

gitguardian bot commented Mar 26, 2024

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
- Generic High Entropy Secret 847e434 tests/fixtures/ring_oauth.json View secret
- Generic High Entropy Secret 847e434 tests/fixtures/ring_oauth.json View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@coveralls
Copy link

coveralls commented Mar 26, 2024

Coverage Status

coverage: 79.015% (-0.8%) from 79.822%
when pulling 4796d3a on sdb9696:make_lib_async
into 8d4f555 on tchellomello:master.

@sdb9696 sdb9696 force-pushed the make_lib_async branch 2 times, most recently from c5c000c to 792a671 Compare March 26, 2024 14:51
@sdb9696 sdb9696 force-pushed the make_lib_async branch 4 times, most recently from 7c5b20c to 4796d3a Compare April 3, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants