copy & paste #33
Open
copy & paste #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Thanks |
|
I have added the buttons copy and paste to each chars.
I need some special chars with accents for french, spanish, etc. so I think
to extract the full range of chars from a font and then remap the ones that I
need in some unused pos.
Il sab 29 gen 2022, 12:12 tchap ***@***.***> ha scritto:
… Hi
What is the purpose of this PR ?
Thanks
—
Reply to this email directly, view it on GitHub
<#33 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAQ3UKUQO4ADICUIN2BRVHLUYPDRXANCNFSM5NCQNRMQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
It seems that they are a lot of changes in your commits that are not related to that (putting scripts in different files, indentation, etc) so I cannot merge as-is. Try to extract that specific feature (copy & paste) so the changeset is readable and contained so I can review it thanks ! |
|
Ok, I'll do that.
Il sab 29 gen 2022, 13:59 tchap ***@***.***> ha scritto:
… It seems that they are a lot of changes in your commits that are not
related to that (putting scripts in different files, indentation, etc) so I
cannot merge as-is.
Try to extract that specific feature (copy & paste) so the changeset is
readable and contained so I can review it
thanks !
—
Reply to this email directly, view it on GitHub
<#33 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAQ3UKSBLJ3NFZPJ7QTTHSDUYPQDFANCNFSM5NCQNRMQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
I have reverted the changes then added just the few lines to do the copy and paste. Now the 2 branches are comparable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.