Skip to content

Commit

Permalink
build: relax the version constraint for Protobuf
Browse files Browse the repository at this point in the history
as higher versions of Protobuf does not claim to be compatible with
v2.5.0, so we have to specify a range of versions which is acceptable
by Seastar. please note Protobuf is using an interesting versioning:
the library is versioned with v21.x, etc. while the C++ APIs are
versioned like v3.21.x, v4.22, etc. if we find the package using
config mode, we search with its library version, otherwise we
search using its C++ API version.

Refs scylladb#2113
Signed-off-by: Kefu Chai <[email protected]>
  • Loading branch information
tchaikov committed Mar 6, 2024
1 parent 47c7484 commit ddef7a2
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions cmake/SeastarDependencies.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -159,14 +159,14 @@ macro (seastar_find_dependencies)
# ProtobufConfig.cmake provided by protobuf defines this linkage. so we try
# the CMake package configuration file first, and fall back to CMake's
# FindProtobuf module.
find_package (Protobuf 2.5.0
find_package (Protobuf 22.0...25.3
QUIET CONFIG)
if (Protobuf_FOUND)
# do it again, so the message is printed when the package is found
find_package(Protobuf 2.5.0
find_package(Protobuf 22.0...25.3
CONFIG REQUIRED)
else ()
find_package(Protobuf 2.5.0
find_package(Protobuf 2.5.0...4.25.3
REQUIRED)
endif ()
endmacro ()

0 comments on commit ddef7a2

Please sign in to comment.