Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ add notes history for Promise.withResolvers() #508

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

✨ add notes history for Promise.withResolvers() #508

wants to merge 1 commit into from
+5 −2

Conversation

ctcpip
Copy link
Member

@ctcpip ctcpip commented Feb 14, 2024

No description provided.

@ctcpip ctcpip mentioned this pull request Feb 14, 2024
Open
ljharb
ljharb reviewed Feb 14, 2024
View reviewed changes
finished-proposals.md Outdated Show resolved Hide resolved
@ljharb
Copy link
Member

ljharb commented Feb 14, 2024

Looks pretty good! altho at this point it seems better to use the <br />s than the commas - on my screen it's always one per line anyways.

@ctcpip
Copy link
Member Author

ctcpip commented Feb 14, 2024 •
edited

two lines for me

Screenshot 2024-02-14 at 5 20 49 PM

edit: no, I am not zoomed out 😅

@ljharb
Copy link
Member

ljharb commented Feb 14, 2024

very strange, keep the commas then.

@ctcpip ctcpip force-pushed the history-example branch 2 times, most recently from bce81cd to 06c5f39 Compare February 15, 2024 07:48
ljharb
ljharb reviewed Feb 15, 2024
View reviewed changes
finished-proposals.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb left review comments

@christceder christceder christceder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ctcpip @ljharb @christceder