Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meta: Upgrade ESMeta to v0.4.1 #3325

Merged
merged 1 commit into from
May 22, 2024
Merged

Meta: Upgrade ESMeta to v0.4.1 #3325

merged 1 commit into from
May 22, 2024

Conversation

jhnaldo
Copy link
Contributor

@jhnaldo jhnaldo commented May 10, 2024

We updated the version of ESMeta to v0.4.0.

We updated the version of ESMeta to v0.4.1 to resolve the issue es-meta/esmeta#220 by this PR es-meta/esmeta#222.

Copy link
Contributor

@bakkot bakkot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Member

@michaelficarra michaelficarra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I would love to work with you to reduce esmeta-ignore.json, or at least categorise and understand the unsupported phrasing.

@jhnaldo jhnaldo changed the title Meta: Upgrade ESMeta to v0.4.0 Meta: Upgrade ESMeta to v0.4.1 May 20, 2024
@jhnaldo
Copy link
Contributor Author

jhnaldo commented May 20, 2024

@michaelficarra I'm also happy to work with you to reduce the esmeta-ignore.json file. I'm categorizing the reason why each type mismatch occurs. After finishing this job, will we discuss it here or in another issue thread?

@bakkot bakkot added the ready to merge Editors believe this PR needs no further reviews, and is ready to land. label May 21, 2024
@michaelficarra
Copy link
Member

@jhnaldo Another thread for it would be great.

@ljharb ljharb merged commit 246b8fa into tc39:main May 22, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Editors believe this PR needs no further reviews, and is ready to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants