Change not found behaviour to just redirect to index #13
Conversation
|
@TilCreator please check if requests for e.g. |
|
It gets ignored, but it executes the scan again, so I changed it to redirect every url containing |
| if 'favicon' in url: | ||
| send_header(client, status_code=404) | ||
| else: | ||
| send_header(client, status_code=307, redirect='/') |
There was a problem hiding this comment.
can you explain why this is an improvement?
There was a problem hiding this comment.
I see now, that this would only be necessary if a custom DNS was in use, but like this it is only a very minor improvement of 404 handling and even that is debatable.
There was a problem hiding this comment.
not sure what you mean.
but in general, a simple and direct error handling is preferable (just say there is a problem and what the problem is). if one introduces some magic instead of that, it often makes finding problems more complicated, hides problems.
There was a problem hiding this comment.
Proceed as you wish.
This removes the 404 page and replaces it with a redirect with the
LocationHTTP header.