Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable initialization script injection into subframes on macOS #1251

Merged
merged 4 commits into from May 13, 2024

Conversation

chippers
Copy link
Member

@chippers chippers commented May 9, 2024

This matches the current behavior of Linux and (mostly) Windows. Windows differs slightly since it still injects subscripts to subframes on the same origin as the main frame.

@chippers chippers requested review from lucasfernog and a team May 9, 2024 14:35
@chippers chippers self-assigned this May 9, 2024
@chippers chippers requested a review from a team as a code owner May 9, 2024 14:35
@chippers chippers removed the request for review from a team May 9, 2024 15:38
@wusyong wusyong merged commit 4f37661 into v0.24.1 May 13, 2024
7 checks passed
@wusyong wusyong deleted the feat/0.24-disable-subframes-on-macos branch May 13, 2024 05:43
pewsheen added a commit that referenced this pull request May 14, 2024
wusyong pushed a commit that referenced this pull request May 14, 2024
@pewsheen
Copy link
Contributor

@chippers Do we need to patch dev branch as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants