Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(cli&bundler): avoid renaming main executable and preserve cargo name #9375

Open
wants to merge 14 commits into
base: dev
Choose a base branch
from

Conversation

amrbashir
Copy link
Member

closes #8109
closes #8349

@amrbashir amrbashir requested a review from a team as a code owner April 4, 2024 00:46
@amrbashir
Copy link
Member Author

cc @FabianLars this will affect tauri-action, can you please give this a test

@FabianLars
Copy link
Member

cc @FabianLars this will affect tauri-action, can you please give this a test

We already have logic in place to read the cargo.toml file so this should be an easy change. I will open a pr once this one here is merged (or earlier if i'm bored lol)

@ninjadev64
Copy link

Hi,

I'm close to releasing a stable version of my app, and I would like to have my app's proper name in releases :P (#8349)

Could this be merged ASAP?

Thanks

@FabianLars
Copy link
Member

FabianLars commented Apr 26, 2024

We can (almost) never promise when something gets merged, but you can always use tauri from git if you can't wait for us :) https://tauri.app/v1/guides/faq#how-can-i-use-unpublished-tauri-changes (just replace dev/1.x with this PR's branch)

@lucasfernog lucasfernog changed the title refactor(cli&bundler): avoid renaming main executable and reserve cargo name refactor(cli&bundler): avoid renaming main executable and preserve cargo name May 24, 2024
@lucasfernog
Copy link
Member

Pushed a small change to use the product name for the installers. I'm not sure about the Linux ones though - maybe we keep using the binary name? @FabianLars @amrbashir

@amrbashir
Copy link
Member Author

amrbashir commented May 25, 2024

It is fine for the installers, not sure about how it will affect linux bundle as well but should be fine to change as well, even macOS if possible. It is just a filename

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants