-
Notifications
You must be signed in to change notification settings - Fork 489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added a splashscreen lab #2106
base: v2
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for tauri-v2 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
cfa43ab
to
2d4e164
Compare
14d70c6
to
9986647
Compare
It's not perfect yet but it's close enough now where I'd like some input on it. 😄 |
I'm just looking at it right now lol, good timing |
what do you think of adding the full CLI as a way to quick start?
|
I'm gonna follow the lab and give my feedback based on it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well, even after the requested changed it doesn't work. Tried to fix it, broke even more. I could give another shot, or do you want to do it yourself?
Is the goal to teach about state? Because if not, I think, if possible, it should be done without it. Or else, add a requirement lab that teaches about managing state. Speaking of which, I've read many times your webpage about state and it helped me A LOT when I needed it , really!
```rust | ||
// /src-tauri/src/lib.rs | ||
// Import functionalities we'll be using | ||
use tauri::async_runtime::spawn; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use tauri::async_runtime::spawn; | |
use tauri::{async_runtime::spawn, State, AppHandle}; |
// Fake performing some heavy action for 3 seconds | ||
println!("Performing really heavy backend setup task..."); | ||
sleep(Duration::from_secs(3)).await; | ||
println!("Backend setup task completed!") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
println!("Backend setup task completed!") | |
println!("Backend setup task completed!"); |
backend_task: false | ||
})) | ||
// Add a command we can use to check | ||
.invoke_handler(tauri::generate_handler!([check_completion])) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.invoke_handler(tauri::generate_handler!([check_completion])) | |
.invoke_handler(tauri::generate_handler![set_complete]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or the function could be renamted to check_completion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome job @simonhyll, I left just a tiny suggestion 🫡
</div> | ||
</body> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that you missed adding a closing tag for the parent div
here.
</div> | |
</body> | |
</div> | |
</div> | |
</body> |
51a4063
to
e4214c9
Compare
What kind of changes does this PR include?
Description
Adds a new splashscreen lab.