v2 migration: guides/building to next
#1731
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for tauri-docs-starlight ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
including links from past migrated `develop` guides
vasfvitor
commented
Dec 20, 2023
Comment on lines
273
to
275
| {/* TODO: Check distribute links once those are in */} | ||
| [windows code signing with github actions]: /guides/distribute/sign-windows#bonus-sign-your-application-with-github-actions | ||
| [macos code signing with github actions]: /guides/distribute/sign-macos#example |
There was a problem hiding this comment.
links breaking the build, from /guides/distrubute to be migrated
There was a problem hiding this comment.
Let's point to prod for now (https://tauri.app/foo...) to get this through and then we can update later.
There was a problem hiding this comment.
so, I was looking at the pages that was changed over and turns out if I understand correctly from the Discord thread, it's the Code Signing pages. Now we can link them here in /build
…r/tauri-docs into migrate-guides-building
vasfvitor
changed the title
guides/building to nextguides/building to next
|
@vasfvitor is this one ready for a full review now? |
|
@lorenzolewis yeah it is |
|
consider #1961 changes |
simonhyll
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's no need to review now, just need a feedback on the last item on TODO list (Revise Copy)What kind of changes does this PR include?
Description
Diff at: f101f88
The Checklist' TOC changes on
app-size.mdwas made automagically so I decided to keep them if that's okPages:
https://tauri.app/v1/guides/building/
https://tauri.app/v1/guides/building/windows
https://tauri.app/v1/guides/building/macos
https://tauri.app/v1/guides/building/linux
https://tauri.app/v1/guides/building/cross-platform
https://tauri.app/v1/guides/building/app-size
https://tauri.app/v1/guides/building/sidecar
https://tauri.app/v1/guides/building/resources
TODO:
Now I'm wondering, if we change those, how will it be for folks utilizing v1?
I was thinking of transformingI guess it's better to keep it as is just to avoid text duplication and possible different translations_tauri-build.mdxinto a fragment ascta.mdxbut leave only tabs, then text contents will be placed on each two page with