Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18zh-cn: Upgrade & Migrate -> Upgrade from Tauri 1.0 #1644

Closed
wants to merge 9 commits into from

Conversation

Wind-Explorer
Copy link

What kind of changes does this PR include?

  • Translated content for Tauri 2.0 docs

Description

  • zh-cn translation of Upgrade from Tauri 1.0 page under Upgrade & Migrate page.

@netlify
Copy link

netlify bot commented Oct 24, 2023

Deploy Preview for tauri-v2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 6ff8331
🔍 Latest deploy log https://app.netlify.com/sites/tauri-v2/deploys/665491a78714a90008d88cef
😎 Deploy Preview https://deploy-preview-1644--tauri-v2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 99 (🔴 down 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@lorenzolewis
Copy link
Member

Thanks for this! @dklassic would you be able to help out with a review on this one?

Copy link
Contributor

@dklassic dklassic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing!

I find the translation to be pretty good, but besides on particular direct change suggestion, I'd like to ask you to do another sweep to improve the reading experience:

  • Ensure a space is in between Chinese characters and half sized characters.
  • Remove redundant space between two full sized characters (both Chinese characters and punctuations).
  • Properly replace half sized punctuation with full sized Chinese punctuations, e.g. use ":" instead of ": ".

Also regarding inline translation of technical term coexisting with the original term, for example in the case of "迁移 Path 路径 至 Tauri Manager 管理器" the formatting is rather confusing to read. I would suggest to use brackets to the mark translated term, i.e. "迁移 Path(路径)至 Tauri Manager(管理器)"

@simonhyll simonhyll added this to the Version 2.0 milestone Feb 26, 2024
@simonhyll simonhyll requested a review from a team February 29, 2024 00:58
@simonhyll simonhyll added i18n Is this related to translations? i18n: zh-cn Is this related to zh-cn translations? labels May 23, 2024
@github-actions github-actions bot removed the i18n Is this related to translations? label May 27, 2024
Wind-Explorer and others added 2 commits May 27, 2024 15:26
Addressed points brought up by @dklassic, polished some improvable translations and translated new content.
@Wind-Explorer Wind-Explorer marked this pull request as draft May 27, 2024 09:11
@Wind-Explorer
Copy link
Author

Seems I'm a bit late to the party, translations for this particular page has been completed by #1967. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n: zh-cn Is this related to zh-cn translations?
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants