Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dialog): Android manifest documentation #1147

Open
wants to merge 5 commits into
base: v2
Choose a base branch
from
Open

fix(dialog): Android manifest documentation #1147

wants to merge 5 commits into from
+25 −0

Conversation

otamam818
Copy link
Contributor

As discussed in this draft pull request, added a section to this documentation that shows users how to add Android integration for external files in the dialog plug-in.

Feel free to change the explanation to suit the project

@otamam818 otamam818 requested a review from a team as a code owner April 5, 2024 12:18
@otamam818
Copy link
Contributor Author

UPDATE: I started working on including Android permissions within the Kotlin code of plugins-workspace/dialog and I imo this PR should be kept on hold from merging until that part is done (else it might be misleading to future users). Once I make a PR to include runtime permissions, I'll come back to this PR and update it accordingly

@amrbashir
Copy link
Member

@otamam818 thank you for your work, let me know when you want me to review

@bpevs bpevs mentioned this pull request Apr 15, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@otamam818 @amrbashir