feat: Add MatterMost remote #508
Conversation
Adds a basic mattermost remote to handle recieving webhook events and posting messages with the API.
JamesMConroy
requested review from
delta592,
wass3rw3rk,
sjqnn and
JordanSussman
as code owners
|
thanks for the PR and apologies for the delay, i will give it a look in the coming days. also, looking to test it on a real or fake mattermost instance |
|
No worries @wass3rw3rk stuff happens and I've had PRs sit idle for longer. This did work with that local mattermost development container, but it didn't work with my company's MatterMost. We use the version packaged with Gitlab Omnibus and it's a pain to test against because it is in a sandbox environment. I don't know if it is our configuration or an issue with how I'm using the websocket library, but I would get a panic when trying to connect. |
| // instantiate a new mattermost client. | ||
| func (c *Client) new() *model.Client4 { | ||
| log.Info().Msgf("%#v", c) | ||
| api := model.NewAPIv4Client("http://" + c.Server) |
There was a problem hiding this comment.
presumably server is not typically on http but https? should the expectation be to provide a FQDN for the MATTERMOST_SERVER configuration item?
There was a problem hiding this comment.
Yea, it probably should default to https.
I'd like to keep the ability to set MATTERMOST_SERVER as a bare IP address, if for no other reason than testing.
What's the best way to allow the user to connect over http if that's what they want? An optional MATTERMOST_SECURE_PROTOCOL variable or something like that?
There was a problem hiding this comment.
i think i would default to secure: https + wss and add a flag like you said. maybe inverse though, something like MATTERMOST_USE_INSECURE or MATTERMOST_LOCAL? not sure if local is the only use-case, so maybe the former?
| c.BotID = user.Username | ||
| } | ||
|
|
||
| sock, err := model.NewWebSocketClient4("ws://"+c.Server, c.Token) |
There was a problem hiding this comment.
Similar to previous comment, I presume this would be wss: for most installations?
There was a problem hiding this comment.
Yep I'll update that. It might be the issue I'm seeing with my work instance.
| MATTERMOST_CHANNEL= | ||
| MATTERMOST_USERNAME= |
There was a problem hiding this comment.
these seem to be unused? is this for future work?
There was a problem hiding this comment.
I think I added them expecting them to be needed but never got around to using them. They might be nice in the future, but I'll remove them until/unless I find a need.
Proposed change
Adds a basic mattermost remote to handle receiving webhook events and posting messages with the API.
Should resolve #97
Types of changes
What types of changes is this pull request introducing to flottbot? Put an
xin the boxes that applyChecklist
You can fill this out after creating your PR. Put an
xin the boxes that applyTesting
To test I used the docker image and add user script from the MM bot example repo https://github.com/mattermost-community/mattermost-bot-sample-golang