ci: add a workflow to check for entrypoint tags #9912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check check-entrypoint.sh comment for explanation of what entrypoint tag is. The workflow fails if current branch does not have a most recent entrypoint tag that it should have. NO_TEST=ci NO_CHANGELOG=ci NO_DOC=ci
locker
approved these changes
Apr 5, 2024
| @@ -0,0 +1,89 @@ | |||
| #!/bin/bash | |||
| # vim: set ts=4 sts=4 sw=4 et: | |||
|
|
||
| if ! git --version >/dev/null 2>&1; then | ||
| error "git must be installed." | ||
| fi |
There was a problem hiding this comment.
I don't think we need to explicitly check presence of git. The script will fail with a proper error message if it isn't available.
| startsWith(github.ref, 'refs/tags/')) && | ||
| format('{0}-{1}', github.run_id, github.run_attempt) || | ||
| format('{0}-{1}', github.workflow, github.ref) }} | ||
| cancel-in-progress: true |
There was a problem hiding this comment.
Since this job works only for the release branches and it's pretty short, I don't think we need to bother with cancelling in-progress jobs, but that's up to devx.
| # We need to find the commit that starts this branch (i.e. that the first | ||
| # commit on this branch after the commit that is common for two branches.) | ||
| # | ||
| # In order to archive this we find all the commits of this branch that |
There was a problem hiding this comment.
Please rename to check-entrypoint-tag.sh.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check check-entrypoint.sh comment for explanation of what entrypoint tag is. The workflow fails if current branch does not have a most recent entrypoint tag that it should have.
Part of #8319