box: prevent demoted leader from being a candidate in the next elections #10003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CuriousGeorgiy
force-pushed
the
gh-9855-demote-self-vote
branch
from
1daa7b9
to
d393e66
Compare
Serpentian
requested changes
May 12, 2024
test/replication-luatest/gh_9855_box_ctl_demote_guarantee_demoting_test.lua
Outdated
Show resolved
Hide resolved
CuriousGeorgiy
force-pushed
the
gh-9855-demote-self-vote
branch
from
d393e66
to
7043a97
Compare
Serpentian
approved these changes
May 14, 2024
CuriousGeorgiy
force-pushed
the
gh-9855-demote-self-vote
branch
2 times, most recently
from
08567b4
to
edc283a
Compare
Serpentian
reviewed
May 15, 2024
CuriousGeorgiy
force-pushed
the
gh-9855-demote-self-vote
branch
from
edc283a
to
c05f6dc
Compare
xuniq
approved these changes
May 16, 2024
sergepetrenko
requested changes
May 17, 2024
test/replication-luatest/gh_9855_box_ctl_demote_guarantee_demoting_test.lua
Show resolved
Hide resolved
Suggested by Nikita Zheleztsov in the scope of tarantool#9855. Needed for tarantool#9855 NO_CHANGELOG=<refactoring> NO_DOC=<refactoring> NO_TEST=<refactoring> Co-authored-by: Nikita Zheleztsov <[email protected]>
CuriousGeorgiy
force-pushed
the
gh-9855-demote-self-vote
branch
from
c05f6dc
to
31d4b92
Compare
CuriousGeorgiy
force-pushed
the
gh-9855-demote-self-vote
branch
4 times, most recently
from
8e7c77a
to
b3284e1
Compare
sergepetrenko
requested changes
May 24, 2024
CuriousGeorgiy
force-pushed
the
gh-9855-demote-self-vote
branch
3 times, most recently
from
546b8e3
to
388de0a
Compare
|
@CuriousGeorgiy, some tests still fail in CI: |
Currently, the demoted leader sees that nobody has requested a vote in the newly persisted term (because it has just written it without voting, and nobody had time to see the new term yet), and hence votes for itself, becoming the most probable winner of the next elections. To prevent this from happening, let's forbid the demoted leader to be a candidate in the next elections using `box_raft_leader_step_off`. Closes tarantool#9855 NO_DOC=<bugfix> Co-authored-by: Serge Petrenko <[email protected]>
CuriousGeorgiy
force-pushed
the
gh-9855-demote-self-vote
branch
from
388de0a
to
374f8c9
Compare
CuriousGeorgiy
added
static-build-ci
@sergepetrenko fixed: added a synchronization point to wait for the restarted server to synchronize with the leader. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch prevents the demoted leader from being a candidate in the next elections.
Closes #9855