hide progress bar if quiet flag is on #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talis-fb
requested changes
Mar 3, 2024
| @@ -30,20 +31,23 @@ impl BasicRequestExecutor<CrosstermCliWriter, CrosstermCliWriter, CrosstermCliWr | |||
| if view_options.print_body_only { | |||
| BasicRequestExecutor { | |||
| request, | |||
| progress_draw_target: ProgressDrawTarget::stderr(), | |||
There was a problem hiding this comment.
Instead insert this ProgressDrawTarget in struct, use just a booleand field, like "show_loading". And check this value for hide or show the loading.
The CommandExecutor dependencies should be decoupled as possible of crate we are using to print stuff. If we need to change from Indicatif or Crossterm for another crate, the change doesn't be so painful.
| @@ -105,6 +109,7 @@ where | |||
| let now = tokio::time::Instant::now(); | |||
|
|
|||
| let pb = ProgressBar::new(100); | |||
| pb.set_draw_target(self.progress_draw_target); | |||
There was a problem hiding this comment.
Does the check mentioned previously
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Further work on #24