Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Company Profile Page #614

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Company Profile Page #614

wants to merge 2 commits into from

Conversation

helloanil
Copy link
Contributor

What should the reviewer know?

Profile works as intended with one blip, that being that job postings on the page do not appear due to current permission errors with the loopback api for retrieving the job postings of a company id not allowing for a jobseeker to hit this api. The code to enable this from the front end is there on the company profile, but is commented out until the api issue can be resolved.

Other than that, the profile page exists at /app/company-profile/, and contains all the normal profile info from the editable version, just in non-editable form - similar to how it works for a job-seeker. The page is linked on both the joblisting card, as well as from a joblisting page

Images

image

joblistingcardanchor

joblistingpageanchor

@helloanil helloanil marked this pull request as draft November 10, 2022 09:39
@gitguardian
Copy link

gitguardian bot commented Apr 27, 2023

⚠️ GitGuardian has uncovered 4 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
753993 Generic High Entropy Secret b3e7f20 nx.json View secret
753993 Generic High Entropy Secret ad5445b nx.json View secret
753993 Generic High Entropy Secret 863d333 nx.json View secret
753993 Generic High Entropy Secret e7ef109 nx.json View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant