Add container utility class (default, centered & with padding)
#13391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey thanks for the PR! Going to hold off on this one for now because I'm not quite sure if we want to include it by default in v4 or make it something you optionally import via a CSS import we ship. Will revisit after we've figured out the custom styles/plugins story 馃憤 Thanks regardless! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to fix the issue #13129
It adds the default declarations for the
containerutility class and it also supports options like centering and padding by using new optional CSS var in thetheme.css.I also added tests to demonstrates the usage.
Feedbacks are welcome 馃憤