Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added utils for filter #1421

Open
wants to merge 12 commits into
base: develop
Choose a base branch
from
Open

added utils for filter #1421

wants to merge 12 commits into from

Conversation

AvineshTripathi
Copy link
Collaborator

@AvineshTripathi AvineshTripathi commented May 14, 2024 •
edited

No description provided.

@AvineshTripathi AvineshTripathi marked this pull request as draft May 14, 2024 05:49
@AvineshTripathi AvineshTripathi marked this pull request as ready for review May 19, 2024 11:02
Azanul
Azanul requested changes May 20, 2024
View reviewed changes
Copy link
Collaborator

@Azanul Azanul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. The queries are predefined, we don't want to update any, rendering the lock & UpdateQuery needless.
  2. resourceCountOutput & regionCountOuput are same, can define a common one

Azanul
Azanul requested changes May 22, 2024
View reviewed changes
Copy link
Collaborator

@Azanul Azanul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can still se the UpdateQuery function and related mutex

Azanul
Azanul requested changes May 22, 2024
View reviewed changes
Copy link
Collaborator

@Azanul Azanul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than that, LGTM

controller/resources.go Outdated Show resolved Hide resolved
@Azanul
Copy link
Collaborator

Azanul commented May 23, 2024

@AvineshTripathi CI filing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Azanul Azanul Azanul approved these changes

@mlabouardy mlabouardy Awaiting requested review from mlabouardy mlabouardy is a code owner

@greghub greghub Awaiting requested review from greghub greghub is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AvineshTripathi @Azanul