MainViewModel: treat NoState -> Starting as starting #396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kari-ts
force-pushed
the
kari/connectbug
branch
2 times, most recently
from
6054335
to
0b39c1e
Compare
agottardo
reviewed
May 16, 2024
| } | ||
| val string = App.get().getString(resId) |
There was a problem hiding this comment.
Suggested change
| val string = App.get().getString(resId) |
Looks like string is not used?
agottardo
approved these changes
May 16, 2024
Toggle should be on when user transitions from NoState -> Starting, but not when the user is in NoState. This change uses a placeholder string "--" when the user is in NoState. Fixes tailscale/corp#19961 Signed-off-by: kari-ts <[email protected]>
kari-ts
added a commit
that referenced
this pull request
May 16, 2024
Toggle should be on when user transitions from NoState -> Starting, but not when the user is in NoState. This change uses a placeholder string "--" when the user is in NoState. Fixes tailscale/corp#19961 Signed-off-by: kari-ts <[email protected]>
kari-ts
added a commit
that referenced
this pull request
May 29, 2024
Toggle should be on when user transitions from NoState -> Starting, but not when the user is in NoState. This change uses a placeholder string "--" when the user is in NoState. Fixes tailscale/corp#19961 Signed-off-by: kari-ts <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
screen-20240514-122554.mp4
Toggle should be on when user transitions from NoState -> Starting, but not when the user is in NoState. This change uses a placeholder string "--" when the user is in NoState.
Fixes tailscale/corp#19961