Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: format runtime errors #2014

Closed
wants to merge 26 commits into from
Closed

feat: format runtime errors #2014

wants to merge 26 commits into from

Conversation

mehulmathur001
Copy link
Contributor

@mehulmathur001 mehulmathur001 commented May 23, 2024 •
edited by tusharmath
Loading

/claim #1508
/fixes #1508

  • Drop color from core::Error
  • GRPC Error
image

@algora-pbc algora-pbc bot mentioned this pull request May 23, 2024
Open
@github-actions github-actions bot added the type: feature Brand new functionality, features, pages, workflows, endpoints, etc. label May 23, 2024
@github-actions GitHub Actions
Copy link

Action required: PR inactive for 2 days.
Status update or closure in 5 days.

@github-actions github-actions bot added the state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. label May 25, 2024
@github-actions GitHub Actions
Copy link

PR closed after 5 days of inactivity.

@github-actions github-actions bot closed this May 30, 2024
@mehulmathur16 mehulmathur16 reopened this Jun 1, 2024
@github-actions github-actions bot removed the state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. label Jun 1, 2024
@codecov Codecov
Copy link

codecov bot commented Jun 2, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 86.90476% with 44 lines in your changes missing coverage. Please review.

Project coverage is 83.97%. Comparing base (1fd3661) to head (5cf1cae).

❗ Current head 5cf1cae differs from pull request most recent head c830fd9

Please upload reports for the commit c830fd9 to get more accurate results.

Files Patch % Lines
src/core/error.rs 89.66% 28 Missing ⚠️
src/core/ir/error.rs 77.41% 7 Missing ⚠️
src/cli/telemetry.rs 0.00% 2 Missing ⚠️
src/cli/error.rs 0.00% 1 Missing ⚠️
src/cli/server/http_1.rs 50.00% 1 Missing ⚠️
src/cli/server/http_2.rs 0.00% 1 Missing ⚠️
src/cli/tc.rs 0.00% 1 Missing ⚠️
src/core/http/response.rs 50.00% 1 Missing ⚠️
src/core/ir/io.rs 93.75% 1 Missing ⚠️
src/main.rs 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2014      +/-   ##
==========================================
- Coverage   84.08%   83.97%   -0.11%     
==========================================
  Files         211      210       -1     
  Lines       19818    19664     -154     
==========================================
- Hits        16663    16513     -150     
+ Misses       3155     3151       -4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 6, 2024

Action required: PR inactive for 2 days.
Status update or closure in 5 days.

@github-actions github-actions bot added state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. and removed state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. labels Jun 6, 2024
tusharmath and others added 9 commits June 8, 2024 17:55
@tusharmath
update snapshots
4995523
@mehulmathur001 @renovate
refactor: EvaluationError to Error (#2)
61d983e 
* chore(deps): update dependency tsx to v4.13.3

* chore(deps): update rust crate async-graphql to v7.0.6

* refactor: rename EvaluationError to Error

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@mehulmathur001
Merge branch 'main' into fix/runtime-err
0457e71
@mehulmathur16
Merge branch 'main' into fix/runtime-err
3786779
@mehulmathur001
Merge branch 'main' into fix/runtime-err
dae6602
@tusharmath
revert some unnecessary changes
5cf1cae
@tusharmath
rename error to errata
276b12b
@tusharmath
Merge branch 'main' into fix/runtime-err
b9f687c
@tusharmath
update snapshots
c830fd9
@tusharmath
Copy link
Contributor

/tip 100 @mehulmathur001

@tusharmath tusharmath closed this Jun 9, 2024
@algora-pbc Algora PBC
Copy link

algora-pbc bot commented Jun 9, 2024

🎉🎈 @mehulmathur001 has been awarded $100! 🎈🎊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🙋 Bounty claim 💰 Rewarded type: feature Brand new functionality, features, pages, workflows, endpoints, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Format runtime errors using CLIError
3 participants
@mehulmathur001 @tusharmath @mehulmathur16