Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: hyper v1 #2013

Open
wants to merge 28 commits into
base: main
Choose a base branch
from
Open

chore: hyper v1 #2013

wants to merge 28 commits into from

Conversation

ssddOnTop
Copy link
Member

Issue Reference(s):
Fixes #650
/claim 650

@algora-pbc algora-pbc bot mentioned this pull request May 23, 2024
Open
@github-actions github-actions bot added ci: benchmark Runs benchmarks type: chore Routine tasks like conversions, reorganization, and maintenance work. labels May 23, 2024
@ssddOnTop ssddOnTop added type: chore Routine tasks like conversions, reorganization, and maintenance work. and removed type: chore Routine tasks like conversions, reorganization, and maintenance work. labels May 23, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented May 23, 2024 •
edited

🐰Bencher

ReportSun, June 2, 2024 at 10:53:05 UTC
Projecttailcall
Branch2013/merge
Testbedbenchmarking-runner

🚨 1 ALERT: Threshold Boundary Limit exceeded!
BenchmarkMeasure (units)ViewValueLower BoundaryUpper Boundary
test_http_execute_methodLatency (nanoseconds (ns))🚨 (view plot | view alert)20,697.00 (+12.62%)19,773.54 (104.67%)

Click to view all benchmark results
BenchmarkLatencyLatency Results
nanoseconds (ns) | (Δ%)		Latency Upper Boundary
nanoseconds (ns) | (%)
group_by✅ (view plot)540.05 (-7.78%)651.90 (82.84%)
input/args.missing✅ (view plot)22.95 (-5.84%)27.23 (84.29%)
input/args.nested.existing✅ (view plot)43.91 (-11.51%)64.68 (67.89%)
input/args.nested.missing✅ (view plot)38.44 (+0.42%)40.67 (94.53%)
input/args.root✅ (view plot)39.06 (-15.20%)61.45 (63.57%)
input/headers.existing✅ (view plot)31.04 (-2.22%)33.64 (92.29%)
input/headers.missing✅ (view plot)30.19 (-1.90%)33.49 (90.15%)
input/value.missing✅ (view plot)23.28 (-0.84%)25.10 (92.76%)
input/value.nested.existing✅ (view plot)40.97 (-1.41%)44.90 (91.26%)
input/value.nested.missing✅ (view plot)37.68 (+3.24%)38.44 (98.01%)
input/value.root✅ (view plot)37.92 (-0.87%)41.56 (91.25%)
input/vars.existing✅ (view plot)7.76 (-3.17%)9.01 (86.12%)
input/vars.missing✅ (view plot)8.36 (-8.27%)12.24 (68.31%)
test_batched_body✅ (view plot)2,617.70 (-99.60%)2,394,111.84 (0.11%)
test_batched_body #2✅ (view plot)1,721,100.00 (+0.36%)1,855,437.61 (92.76%)
test_data_loader✅ (view plot)464,060.00 (-1.30%)488,515.34 (94.99%)
test_handle_request✅ (view plot)149,830.00 (-6.68%)179,935.99 (83.27%)
test_http_execute_method🚨 (view plot | view alert)20,697.00 (+12.62%)19,773.54 (104.67%)
with_mustache_expressions✅ (view plot)1,191.00 (+1.79%)1,235.53 (96.40%)
with_mustache_literal✅ (view plot)744.16 (+2.91%)770.66 (96.56%)

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

@codecov Codecov
Copy link

codecov bot commented May 23, 2024 •
edited

Codecov Report

Attention: Patch coverage is 81.73077% with 57 lines in your changes missing coverage. Please review.

Project coverage is 82.78%. Comparing base (3d5b67a) to head (b0f00a6).
Report is 73 commits behind head on main.

Files Patch % Lines
tailcall-cloudflare/src/http.rs 0.00% 11 Missing ⚠️
src/core/http/telemetry.rs 40.00% 9 Missing ⚠️
src/cli/server/http_2.rs 84.00% 8 Missing ⚠️
src/cli/javascript/js_request.rs 16.66% 5 Missing ⚠️
src/core/http/method.rs 58.33% 5 Missing ⚠️
src/core/http/request_handler.rs 73.68% 5 Missing ⚠️
src/cli/server/http_1.rs 87.09% 4 Missing ⚠️
src/cli/telemetry.rs 0.00% 3 Missing ⚠️
src/cli/javascript/js_response.rs 66.66% 2 Missing ⚠️
src/core/http/response.rs 60.00% 2 Missing ⚠️
... and 2 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2013      +/-   ##
==========================================
- Coverage   82.79%   82.78%   -0.02%     
==========================================
  Files         183      185       +2     
  Lines       18243    18345     +102     
==========================================
+ Hits        15104    15186      +82     
- Misses       3139     3159      +20

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions GitHub Actions
Copy link

Action required: PR inactive for 2 days.
Status update or closure in 5 days.

@github-actions github-actions bot added state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. and removed state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. labels May 27, 2024
@ssddOnTop ssddOnTop removed the ci: benchmark Runs benchmarks label May 27, 2024
@github-actions github-actions bot added the ci: benchmark Runs benchmarks label May 27, 2024
@ssddOnTop ssddOnTop removed the ci: benchmark Runs benchmarks label May 27, 2024
@github-actions GitHub Actions
Copy link

Action required: PR inactive for 2 days.
Status update or closure in 5 days.

@github-actions github-actions bot added state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. and removed state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. labels May 29, 2024
@tusharmath tusharmath added the ci: benchmark Runs benchmarks label May 29, 2024
@github-actions GitHub Actions
Copy link

Action required: PR inactive for 2 days.
Status update or closure in 5 days.

@github-actions github-actions bot added state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. and removed state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. labels May 31, 2024
@shashitnak shashitnak added the ci: lint Automatically fix the linters issues and make a commit label Jun 2, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 4, 2024

Action required: PR inactive for 2 days.
Status update or closure in 5 days.

@github-actions github-actions bot added state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. and removed state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. labels Jun 4, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 6, 2024

Action required: PR inactive for 2 days.
Status update or closure in 5 days.

@github-actions github-actions bot added state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. and removed state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. labels Jun 6, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 8, 2024

Action required: PR inactive for 2 days.
Status update or closure in 5 days.

@github-actions github-actions bot added the state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. label Jun 8, 2024
@ssddOnTop ssddOnTop removed the state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. label Jun 9, 2024
@github-actions GitHub Actions
Copy link

Action required: PR inactive for 2 days.
Status update or closure in 5 days.

@github-actions github-actions bot added the state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. label Jun 11, 2024
@ssddOnTop ssddOnTop removed the state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. label Jun 13, 2024
@github-actions GitHub Actions
Copy link

Action required: PR inactive for 2 days.
Status update or closure in 5 days.

@github-actions github-actions bot added the state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. label Jun 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🙋 Bounty claim ci: benchmark Runs benchmarks ci: lint Automatically fix the linters issues and make a commit state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. type: chore Routine tasks like conversions, reorganization, and maintenance work.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade hyper to 1.0
3 participants
@ssddOnTop @tusharmath @shashitnak