Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Removing schema from @http #1986

Closed
wants to merge 27 commits into from
Closed

chore: Removing schema from @http #1986

wants to merge 27 commits into from

Conversation

mobley-trent
Copy link
Contributor

Summary:
Remove schema from Http directive and all connected code.

Issue Reference(s):
Closes #1978

Build & Testing:

  • I ran cargo test successfully.
  • I have run ./lint.sh --mode=fix to fix all linting issues raised by ./lint.sh --mode=check.

Checklist:

  • I have added relevant unit & integration tests.
  • I have updated the documentation accordingly.
  • I have performed a self-review of my code.
  • PR follows the naming convention of <type>(<optional scope>): <title>

@github-actions github-actions bot added the type: chore Routine tasks like conversions, reorganization, and maintenance work. label May 19, 2024
tusharmath and others added 5 commits May 19, 2024 17:11
@tusharmath
Merge branch 'main' into drop_schema
89bbc1b
@meskill @tusharmath @renovate
fix(grpc): map type support (tailcallhq#1979)
7c7633c 
Co-authored-by: Tushar Mathur <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@TheWizardTower @tusharmath
@meskill @renovate @mehulmathur16
chore: Clean up merge logic for vectors of key-value structs. (tailca…
f421e5a 
…llhq#1977)

Co-authored-by: Tushar Mathur <[email protected]>
Co-authored-by: Kiryl Mialeshka <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Mehul Mathur <[email protected]>
@amitksingh1490
fix: errors on compile time on mac (tailcallhq#2005)
aa2d4b6
@tusharmath
chore: update prettier command
715266f
@github-actions GitHub Actions
Copy link

Action required: PR inactive for 2 days.
Status update or closure in 5 days.

@github-actions github-actions bot added the state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. label May 22, 2024
mobley-trent
mobley-trent commented May 23, 2024
View reviewed changes
src/core/config/n_plus_one.rs Outdated
Vec::new()
}
pub fn n_plus_one() -> Vec<Vec<(String, String)>> {
Vec::new()
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tusharmath How should I handle n_plus_one without schema.query ?

@github-actions github-actions bot removed the state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. label May 23, 2024
@github-actions GitHub Actions
Copy link

Action required: PR inactive for 2 days.
Status update or closure in 5 days.

@github-actions github-actions bot added the state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. label May 25, 2024
@github-actions github-actions bot added the ci: benchmark Runs benchmarks label May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ci: benchmark Runs benchmarks state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. type: chore Routine tasks like conversions, reorganization, and maintenance work.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

drop schema from @http directive
9 participants
@mobley-trent @tusharmath @meskill @TheWizardTower @amitksingh1490 @shashitnak @laststylebender14 @ssddOnTop @mehulmathur16