ci: test release workflow #1982
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meskill
requested changes
May 17, 2024
Comment on lines
+106
to
+110
| permissions: | ||
| contents: write | ||
| pull-requests: write | ||
| env: | ||
| GITHUB_TOKEN: ${{secrets.GITHUBTOKEN}} |
There was a problem hiding this comment.
why do we need these permissions and env?
I don't think we doing anything here except for testing that build is successful
Comment on lines
+12
to
+105
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| build: | ||
| [ | ||
| linux-x64-gnu, | ||
| linux-x64-musl, | ||
| linux-arm64-gnu, | ||
| linux-arm64-musl, | ||
| linux-ia32-gnu, | ||
| darwin-arm64, | ||
| darwin-x64, | ||
| win32-x64-msvc, | ||
| win32-x64-gnu, | ||
| win32-arm64-msvc, | ||
| win32-ia32-gnu, | ||
| ] | ||
| include: | ||
| - build: linux-x64-gnu | ||
| os: ubuntu-latest | ||
| rust: stable | ||
| target: x86_64-unknown-linux-gnu | ||
| libc: glibc | ||
| cross: false | ||
|
|
||
| - build: linux-x64-musl | ||
| os: ubuntu-latest | ||
| rust: stable | ||
| target: x86_64-unknown-linux-musl | ||
| libc: musl | ||
| cross: true | ||
|
|
||
| - build: linux-arm64-gnu | ||
| os: ubuntu-latest | ||
| rust: stable | ||
| target: aarch64-unknown-linux-gnu | ||
| libc: glibc | ||
| cross: true | ||
|
|
||
| - build: linux-arm64-musl | ||
| os: ubuntu-latest | ||
| rust: stable | ||
| target: aarch64-unknown-linux-musl | ||
| libc: musl | ||
| cross: true | ||
|
|
||
| - build: linux-ia32-gnu | ||
| os: ubuntu-latest | ||
| rust: stable | ||
| target: i686-unknown-linux-gnu | ||
| libc: glibc | ||
| cross: true | ||
|
|
||
| - build: darwin-arm64 | ||
| os: macos-latest | ||
| rust: stable | ||
| target: aarch64-apple-darwin | ||
|
|
||
| - build: darwin-x64 | ||
| os: macos-latest | ||
| rust: stable | ||
| target: x86_64-apple-darwin | ||
| cross: false | ||
|
|
||
| - build: win32-x64-msvc | ||
| os: windows-latest | ||
| rust: stable | ||
| target: x86_64-pc-windows-msvc | ||
| libc: msvc | ||
| ext: ".exe" | ||
|
|
||
| - build: win32-x64-gnu | ||
| os: windows-latest | ||
| rust: stable | ||
| target: x86_64-pc-windows-gnu | ||
| libc: glibc | ||
| ext: ".exe" | ||
|
|
||
| - build: win32-arm64-msvc | ||
| os: windows-latest | ||
| rust: stable | ||
| target: aarch64-pc-windows-msvc | ||
| features: --no-default-features --features cli | ||
| libc: msvc | ||
| ext: ".exe" | ||
|
|
||
| - build: win32-ia32-gnu | ||
| os: ubuntu-latest | ||
| rust: stable | ||
| target: i686-pc-windows-gnu | ||
| features: --no-default-features --features cli | ||
| cross: true | ||
| libc: glibc | ||
| ext: ".exe" |
There was a problem hiding this comment.
it'll be hard to maintain this list in multiple places.
We should consider reusing strategy matrix. Probably with the help of https://github.com/druzsan/setup-matrix and https://docs.github.com/en/actions/using-workflows/reusing-workflows
|
Action required: PR inactive for 2 days. |
github-actions
bot
added
the
state: inactive
|
Moving to draft, until the comments are resolved/answered. |
github-actions
bot
removed
the
state: inactive
|
Action required: PR inactive for 2 days. |
github-actions
bot
added
the
state: inactive
|
PR closed after 5 days of inactivity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR adds a workflow for testing release build. This workflow will only be triggered if
ci: test releaselabel is added to a PR.Issue Reference(s):
Fixes #... (Replace "..." with the issue number)
Build & Testing:
cargo testsuccessfully../lint.sh --mode=fixto fix all linting issues raised by./lint.sh --mode=check.Checklist:
<type>(<optional scope>): <title>