Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: generate tailcall config from rest endpoint. #1980

Merged
merged 189 commits into from
Jun 5, 2024

Conversation

laststylebender14
Copy link
Contributor

Summary:
Briefly describe the changes made in this PR.

Issue Reference(s):
Fixes #... (Replace "..." with the issue number)

Build & Testing:

  • I ran cargo test successfully.
  • I have run ./lint.sh --mode=fix to fix all linting issues raised by ./lint.sh --mode=check.

Checklist:

  • I have added relevant unit & integration tests.
  • I have updated the documentation accordingly.
  • I have performed a self-review of my code.
  • PR follows the naming convention of <type>(<optional scope>): <title>

@laststylebender14 laststylebender14 marked this pull request as draft May 17, 2024 06:14
@github-actions github-actions bot added the type: feature Brand new functionality, features, pages, workflows, endpoints, etc. label May 17, 2024
Copy link

codecov bot commented May 17, 2024

Codecov Report

Attention: Patch coverage is 99.01345% with 11 lines in your changes missing coverage. Please review.

Project coverage is 83.78%. Comparing base (9cdf3ef) to head (93c2e96).

Files Patch % Lines
...core/config/transformer/type_merger/type_merger.rs 97.97% 4 Missing ⚠️
src/cli/tc.rs 0.00% 2 Missing ⚠️
src/cli/command.rs 0.00% 1 Missing ⚠️
...rc/core/config/transformer/type_merger/pair_map.rs 90.90% 1 Missing ⚠️
.../core/config/transformer/type_merger/similarity.rs 99.64% 1 Missing ⚠️
...rc/core/generator/json/field_base_url_generator.rs 99.05% 1 Missing ⚠️
src/core/generator/json/url_utils.rs 96.42% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1980      +/-   ##
==========================================
+ Coverage   82.80%   83.78%   +0.97%     
==========================================
  Files         183      198      +15     
  Lines       18278    19379    +1101     
==========================================
+ Hits        15136    16236    +1100     
- Misses       3142     3143       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

- instead of scalar return actual type of primitives.

pub fn to_gql_type(value: &Value) -> String {
match value {
Value::Null => "Empty",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

discuss about this, JSON scalar makes more sense as we're not sure about type.

@laststylebender14 laststylebender14 marked this pull request as ready for review June 4, 2024 12:44
@tusharmath tusharmath enabled auto-merge (squash) June 5, 2024 11:51
@tusharmath tusharmath removed the ci: benchmark Runs benchmarks label Jun 5, 2024
@github-actions github-actions bot added the ci: benchmark Runs benchmarks label Jun 5, 2024
@tusharmath tusharmath disabled auto-merge June 5, 2024 17:53
@tusharmath tusharmath merged commit 5fe4adc into main Jun 5, 2024
27 checks passed
@tusharmath tusharmath deleted the feat/gen-tailcall-config-from-url branch June 5, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci: benchmark Runs benchmarks type: feature Brand new functionality, features, pages, workflows, endpoints, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants