[aot] Proper type checking in C-API header generator #7979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docsite-preview canceled.
|
for more information, see https://pre-commit.ci
|
/rebase |
1 similar comment
|
/rebase |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #
Brief Summary
🤖 Generated by Copilot at 0e63d20
Refactored and fixed bugs in the scripts for generating the C API and the Unity language binding. Improved the JSON schema handling and versioning.
Walkthrough
🤖 Generated by Copilot at 0e63d20
get_declrfunctions ingenerate_c_api.pyandgenerate_unity_language_binding.pyto useisinstanceinstead oftypefor checking the entry type (link, link, link, link, link, link, link, link, link, link, link, link, link, link)generate_c_api.pywhere the enumeration case name was not converted to snake case before passing it toget_api_field_ref(link)generate_unity_language_binding.pywhere the regular expression for matching the module name was missing the raw string prefix (link)generate_c_api.pyandtaichi_json.py(link, link, link, link)taichi_json.pyfor better type checking and readability (link, link, link, link, link, link, link)get_type_namefunction ingenerate_unity_language_binding.pyto useisinstanceinstead oftypefor checking the entry type (link)