Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow usage of version 7.x of the tinymce peer dependency #1864

Merged
merged 1 commit into from Apr 30, 2024

Conversation

cedric-anne
Copy link
Contributor

TinyMCE 7.0 have only some small BC breaks and it should be possible to use the new v7.0.0 version without having any issues.

This would prevent the following error when trying to upgrade to tinymce@^7.0.0:

npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR! 
npm ERR! While resolving: @tabler/[email protected]
npm ERR! Found: [email protected]
npm ERR! node_modules/tinymce
npm ERR!   tinymce@"^7.0.0" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peerOptional tinymce@"^6.4.2" from @tabler/[email protected]
npm ERR! node_modules/@tabler/core
npm ERR!   @tabler/core@"^1.0.0-beta20" from the root project
npm ERR! 
npm ERR! Conflicting peer dependency: [email protected]
npm ERR! node_modules/tinymce
npm ERR!   peerOptional tinymce@"^6.4.2" from @tabler/[email protected]
npm ERR!   node_modules/@tabler/core
npm ERR!     @tabler/core@"^1.0.0-beta20" from the root project

Copy link

vercel bot commented Apr 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
tabler ❌ Failed (Inspect) Apr 2, 2024 2:10pm

@codecalm codecalm merged commit c3b42f9 into tabler:dev Apr 30, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants