You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR aims to resolve the issue mentioned in #1768
Steps taken to resolve the issue:
I created a new variable called $form-secondary-color which would allow us to have a globally initialzed secondary color value for the forms.scss file.
I also declared this variable to be equal to the gray-500 as it was the value for the previous variable(var(--#{$prefix}secondary)).
I replaced the definition of var(--#{$prefix}secondary) to var(--#{$prefix}gray-500) in the _variables.scss file.
I noticed that on local developmental environment, some of the colours are being taken from the demo\dist\css\tabler.css file and I was wondering whether I should change the definition within this file. As based on my understanding, this file is used to deploy a specific version of the application and shouldn't be modified during development.
This change was tested on a Windows environment using the Google Chrome browser. All variables mentioned under the src/ directory are being displayed as expected.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
@codecalm can you please have a look at my PR when you get a chance. Let me know if any changes are required and I'll be more than happy to make them. This is my first ever contribution to open source and I am really looking forward to your input!
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to resolve the issue mentioned in #1768
Steps taken to resolve the issue:
This change was tested on a Windows environment using the Google Chrome browser. All variables mentioned under the src/ directory are being displayed as expected.