Added per-user quota admin api #576
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Michael-Hollister
force-pushed
the
michael/per-user-quotas-admin-api
branch
from
6413675
to
edee81e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently have the ability to set quotas for users in the config file via matching glob patterns. This works well primarily in the case for setting per-domain quotas for users rather than specific users. Although we can set glob entries that match specific users, it does not scale well when having to specify quota values for lots of users. Additionally, repo admins who do not have access to the config file cannot programmatically set user quotas.
To address these current quota limitations, I've added support via the admin API the ability to get and set per-user quotas in the MMR database. By default, the config quota globs take precedence unless a user's quota values are specifically set via the admin API.
See admin API docs for further details regarding endpoints added.