Disable _resolve for IP family if not requested #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szmarczak
requested changes
Aug 4, 2022
szmarczak
reviewed
Aug 4, 2022
|
Can you add a test for this? Just to confirm that it works. |
szmarczak
reviewed
Aug 4, 2022
Getting this error when trying to run the tests on 6.0.4.
|
|
It should just work. Can you try |
|
Nope, just timing out Will check in depth another time |
|
What OS are you running? |
|
MacOS Big Sur
…On Thu, Aug 4, 2022 at 11:30 PM Szymon Marczak ***@***.***> wrote:
What OS are you running?
—
Reply to this email directly, view it on GitHub
<#62 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACIXLXDYQQXCKZYG4U536ZTVXQALLANCNFSM55R7HGDA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
--
Edwin Clement
|
sindresorhus
force-pushed
the
master
branch
from
cb21fa9
to
08a6478
Compare
Mar0xy
pushed a commit
to transfem-org/TransFish
that referenced
this pull request
Aug 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents adding IPv6 resolution if only IPv4 is requested.
We had a client with a misconfigured DNS server that times out and fails with SERVFAIL(on IPv6).
Without this patch, the lookup fails even though the IPv4 promise has been resolved with the IP.