Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: automerge dependabot PRs #895

Merged
merged 3 commits into from
May 3, 2024
Merged

feat: automerge dependabot PRs #895

merged 3 commits into from
May 3, 2024

Conversation

hirasso
Copy link
Member

@hirasso hirasso commented May 2, 2024

Description

A new attempt to automate the process of merging dependabot PRs.

  • for now only for patch version bumps
  • includes a manual trigger for testing it as soon as we have merged it
  • we currently have a whole bunch of open PRs, so this would be a nice chance to test the action
  • if it works, we can inherit the action within the plugins

Checks

  • The PR is submitted to the master branch
  • The code was linted before pushing (npm run lint)

@hirasso hirasso requested a review from daun May 2, 2024 21:09
Copy link

github-actions bot commented May 2, 2024

Size Change: 0 B

Total Size: 22.9 kB

ℹ️ View Unchanged
Filename Size
dist/Swup.modern.js 6.96 kB
dist/Swup.module.js 7.86 kB
dist/Swup.umd.js 8.13 kB

compressed-size-action

@daun
Copy link
Member

daun commented May 2, 2024

Nice! Do you think we'd regret starting with minor right away? I'm quite confident in our tests at this point...

Copy link

github-actions bot commented May 2, 2024

Playwright test results

passed  300 passed
skipped  3 skipped

Details

report  Open report ↗︎
stats  303 tests across 22 suites
duration  1 minute, 21 seconds
commit  6645e6b

Skipped tests

webkit → animation-timing.spec.ts → animation timing → detects animation timing
webkit → animation-timing.spec.ts → animation timing → detects complex animation timing
webkit → animation-timing.spec.ts → animation timing → detects keyframe timing

@hirasso
Copy link
Member Author

hirasso commented May 3, 2024

Alright, it's target: minor now

Copy link
Member

@daun daun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖

@hirasso hirasso merged commit 9ca1519 into master May 3, 2024
12 checks passed
@hirasso hirasso deleted the feat/dependabot-automerge branch May 3, 2024 10:41
@hirasso
Copy link
Member Author

hirasso commented May 3, 2024

This worked nicely. I'll proceed with extending the action in fragment-plugin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants