Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix header location for nextcloud installation #941

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

herrwusel
Copy link

Currently the headers are in the wrong place in the nginx config.

Description

In the current status the recommended headers for a nextcloud installation are not set (can be checked with curl -I tld/nextcloud). This commit fixes the headers.

Fixes issues:

  • Un-tracked issue

Proposed Changes:

  • Put the headers in the right position in the nginx config.

Change Categories

  • Bug fix

Checklist

  • Branch was made off the develop branch and the PR is targetting the develop branch
  • Docs have been made OR are not necessary
    • PR link:
  • Changes to panel have been made OR are not necessary
    • PR link:
  • Code is formatted (See more)
  • Code conforms to project structure (See more)
  • Shellcheck isn't screaming (See more)
  • Prints to terminal are handled (See more)
  • I have commented my code, particularly in hard-to-understand areas
  • Testing was done
    • Tests created or no new tests necessary
    • Tests executed

Currently the headers are in the wrong place in the nginx config.
@liaralabs
Copy link
Member

Hi @herrwusel -- I would be happy to include this. However, in the current state, this will not update current installations. Can you please add an updater script that will check if existing installations need an edit and to apply the edit if found to be out of date?

@herrwusel
Copy link
Author

herrwusel commented Jan 22, 2023

Oh, of course. I will have a look. Are there any previous updater scripts you would recommend?

EDIT: I found the update script for nextcloud. Is it enough if I change the headers' location there? If not, I'm uncertain if I understand correctly which update functionality you are speaking off.

@liaralabs
Copy link
Member

liaralabs commented Apr 15, 2023

Apologies on the very late response here.

Is it enough if I change the headers' location there? If not, I'm uncertain if I understand correctly which update functionality you are speaking off.

Yes it would be sufficient to check if the nextcloud update file contains the location block that shouldn't exist and use that as a trigger for the new code.

Edit: you could just replace the existing trigger with a grep for the new location block and update the config, yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants