Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: LazyLibrarian #772

Open
wants to merge 63 commits into
base: develop
Choose a base branch
from

Conversation

Aethaeran
Copy link
Contributor

Description

Add requested feature lazy librarian

Fixes issues:

  • Issue #nr...
  • Un-tracked issue...

Proposed Changes:

  • Changed xyz...

Change Categories

  • Bug fix
  • New feature
  • Breaking change
  • Change in functions
  • Project structure
  • Contribution flow

Checklist

  • Branch was made off the develop branch and the PR is targetting the develop branch
  • Docs have been made OR are not necessary
    • PR link:
  • Changes to panel have been made OR are not necessary
    • PR link:
  • Code is formatted (See more)
  • Code conforms to project structure (See more)
  • Shellcheck isn't screaming (See more)
  • Prints to terminal are handled (See more)
  • I have commented my code, particularly in hard-to-understand areas
  • Testing was done
    • Tests created or no new tests necessary
    • Tests executed

Test scenarios

Architectures

amd64 armhf arm64 Unspecified
Focal
Bionic
Buster
Stretch
Raspbian ⚫️ ⚫️ ⚫️

✅❎ Passed

🛠🛠 TODO

❌❌ Currently failing

flying-sausages and others added 30 commits August 22, 2021 13:03
This reverts commit 374ee9a.
This reverts commit 8b5d2b1.
Was getting these errors in Deb 10. Adding `apt_install "python3-venv"` rectifies this.

```
    # 23-Aug-2021 14:00:34 - WARNING :: MAIN : __init__.py:initialize:976 : urllib3: missing
    # 23-Aug-2021 14:00:34 - WARNING :: MAIN : __init__.py:initialize:976 : apprise: library missing
    # 23-Aug-2021 14:00:34 - WARNING :: MAIN : __init__.py:initialize:976 : python imaging: library missing
    # 23-Aug-2021 14:00:34 - WARNING :: MAIN : __init__.py:initialize:976 : pyOpenSSL: module missing
```
Also added a default download dir because LazyLib will throw an error in it's log otherwise.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants