Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: improved curlcheck, filebrowser test that needed those #761

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

flying-sausages
Copy link
Member

Description

Fileborwser tests were failign and I needed to add some extra options to allow it

Fixes issues:

Proposed Changes:

  • feat: try first guess port from installed local config
  • feat: add options to supply baseurl and protocol to curl check
  • docs: asd
  • test: filebrowser tests

Change Categories

  • Bug fix
  • New feature
  • Change in functions

Checklist

  • Branch was made off the develop branch and the PR is targetting the develop branch
  • Docs have been made OR are not necessary
    • PR link:
  • Changes to panel have been made OR are not necessary
    • PR link:
  • Code is formatted (See more)
  • Code conforms to project structure (See more)
  • Shellcheck isn't screaming (See more)
  • Prints to terminal are handled (See more)
  • I have commented my code, particularly in hard-to-understand areas
  • Testing was done
    • Tests created or no new tests necessary
    • Tests executed

Test scenarios

Architectures

amd64 armhf arm64 Unspecified
Focal
Bionic
Buster
Stretch
Raspbian ⚫️ ⚫️ ⚫️

✅❎ Passed

🛠🛠 TODO

❌❌ Currently failing

@github-actions github-actions bot added the has conflicts This PR has conflicts against master label Aug 29, 2021
@github-actions github-actions bot removed the has conflicts This PR has conflicts against master label Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant