Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(completions): stop storing lists in swizdb #747

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

flying-sausages
Copy link
Member

Description

Completions were only re-generated on box update, now they're just dynamic

Fixes issues:

  • Storing hardcoded lists

Proposed Changes:

  • missing box it, box rm and box test commands

Change Categories

  • Bug fix
  • Change in functions

Checklist

  • Branch was made off the develop branch and the PR is targetting the develop branch
  • Docs have been made OR are not necessary
    • PR link:
  • Changes to panel have been made OR are not necessary
    • PR link:
  • Code is formatted (See more)
  • Code conforms to project structure (See more)
  • Shellcheck isn't screaming (See more)
  • Prints to terminal are handled (See more)
  • I have commented my code, particularly in hard-to-understand areas
  • Testing was done
    • Tests created or no new tests necessary
    • Tests executed

Test scenarios

Architectures

amd64 armhf arm64 Unspecified
Focal yup
Bionic
Buster
Stretch
Raspbian ⚫️ ⚫️ ⚫️

✅❎ Passed

🛠🛠 TODO

❌❌ Currently failing

@flying-sausages
Copy link
Member Author

@userdocs Just FYI that this is being changed, please let me know if this works for you right the permissions have since been changed (and get checked by CI) so this is now possible, even from non-master users

@flying-sausages
Copy link
Member Author

@brettpetch do you think you could give this one a test?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant