Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: box upgrade --all #724

Open
wants to merge 17 commits into
base: develop
Choose a base branch
from
Open

feat: box upgrade --all #724

wants to merge 17 commits into from

Conversation

flying-sausages
Copy link
Member

@flying-sausages flying-sausages commented Jul 19, 2021

Description

A way to upgrade all box packages

Fixes issues:

  • User requests for box upgrade --all

Proposed Changes:

  • Added box upgrade --all mechanism

Change Categories

  • New feature
  • Project structure

Checklist

  • Branch was made off the develop branch and the PR is targetting the develop branch
  • Docs have been made OR are not necessary
  • Changes to panel have been made OR are not necessary
    • PR link:
  • Code is formatted (See more)
  • Code conforms to project structure (See more)
  • Shellcheck isn't screaming (See more)
  • Prints to terminal are handled (See more)
  • I have commented my code, particularly in hard-to-understand areas
  • Testing was done
    • Tests created or no new tests necessary
    • Tests executed

Test scenarios

Architectures

amd64 armhf arm64 Unspecified
Focal yup
Bionic
Buster
Stretch
Raspbian ⚫️ ⚫️ ⚫️

✅❎ Passed

🛠🛠 TODO

❌❌ Currently failing

@flying-sausages
Copy link
Member Author

@liaralabs do we want to make scripts that would do the appropriate apt install calls for packages that are maintained via apt as well?

@flying-sausages
Copy link
Member Author

image

panel has since been added to the blacklist fyi, as it is done already in `box update`

@she11sh0cked
Copy link

The blacklist leaves spaces behind, which are interpreted as installed packages

ubuntu@seedbox:~$ sudo box upgrade --all
WARN    Not updating /etc/swizzin as a dev lockfile is present.
...     Setting correct permissions on swizzin files
        ✔   Permissions set
...     Updating panel to latest version
...     Pulling new commits
        ✔   Commits pulled
...     Checking pip for new depends
        ✔   Depends up-to-date
...     Restarting Panel
        ✔   Done!
        ✔   Done
INFO    All possible installed packages will be upgraded (except torrent clients)
        Packages that are installed via `apt` will not be upgraded, please attempt those manually
INFO    Packages = ' sonarr web prowlarr plex  bazarr nginx radarr'
bash: /usr/local/bin/swizzin/upgrade/.sh: No such file or directory
ubuntu@seedbox:~$ ls -a /install/
.  ..  .bazarr.lock  .deluge.lock  .delugeweb.lock  .nginx.lock  .panel.lock  .plex.lock  .prowlarr.lock  .radarr.lock  .sonarr.lock

@flying-sausages
Copy link
Member Author

@she11sh0cked thanks for the report! I re-wrote that logic, could you test it again please?

@flying-sausages
Copy link
Member Author

image

@she11sh0cked

This comment has been minimized.

@she11sh0cked

This comment has been minimized.

scripts/box Outdated Show resolved Hide resolved
@she11sh0cked

This comment has been minimized.

@flying-sausages
Copy link
Member Author

I could reproduce it, the issue was in bash interpreting the * in the find command directly. The last commit should fix this.

@brettpetch
Copy link
Member

Have we figgered this one out yet?

@flying-sausages
Copy link
Member Author

Yes

@github-actions github-actions bot added the has conflicts This PR has conflicts against master label Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ez quick merge has conflicts This PR has conflicts against master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants