Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent nginx failing on duplicated configuration lines #1160

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

webavant
Copy link

@webavant webavant commented Apr 26, 2024

Description

Fixes issues:

  • Un-tracked issue: nginx update script creating duplicate server_tokens in nginx's configuration directives is causing nginx service failure on start

Proposed Changes:

  • change behavior to only add server_tokens directive when no match found (rather than when fewer than two matches are found) in nginx config file

Change Categories

  • Bug fix

Checklist

  • Branch was made off the develop branch and the PR is targetting the develop branch
  • Docs have been made OR are not necessary
    • PR link:
  • Changes to panel have been made OR are not necessary
    • PR link:
  • Code conforms to project structure (See more)
  • Prints to terminal are handled (See more)
  • I have commented my code, particularly in hard-to-understand areas
  • Testing was done
    • Tests created or no new tests necessary
    • Tests executed

Test scenarios

Ran shellcheck scripts/update/nginx.sh without any new errors/warnings

Architectures

amd64 armhf arm64 Unspecified
Jammy
Focal
Bookworm
Bullseye
Buster
Raspbian ⚫️ ⚫️ ⚫️

✅❎ Passed

🛠🛠 TODO

❌❌ Currently failing

@webavant webavant changed the title prevent nginx crash on duplicated configuration lines prevent nginx failing on duplicated configuration lines Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant