rTorrent: Optimize mktorrent build script #1145
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mehavoid
reviewed
Mar 24, 2024
stickz
force-pushed
the
mktorrent-improve
branch
7 times, most recently
from
6fb9cea
to
533afc1
Compare
rTorrent: Optimize mktorrent build script
stickz
force-pushed
the
mktorrent-improve
branch
from
533afc1
to
e7f2973
Compare
|
I fixed some errors with mktorrent and libudns, if the script is stopped midway as well. Separated both builds into separate functions to cleanup the code. Added additional error handling for udns if git clone fails. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested on Ubuntu 22.04 LTS. Confirmed to be working.