Fix Jellyfin not installing correctly #1032

KatieTheDev · 2023-07-04T04:29:53Z

Description

Jellyfin split their repositories into two and have explained why here. To accommodate this change, I have updated the installation script and update script to accommodate their new repository changes.

Fixes issues:

Un-tracked issue: Jellyfin stopped installing, giving an error that either a repository was not signed or completely refusing to connect.

Proposed Changes:

Changed the installation script to install the latest signing key.
Changed the installation script to add the new repository depending on the OS and version the user is running.
Changed the update script to remove old signing keys because a previous signing key has expired.
Changed the update script to remove old repositories because the repository has changed.

Change Categories

Bug fix

Checklist

Test scenarios

I tested by running box install and box update using these new scripts. The embedded video was created before I finished work on the update script, but demonstrates how both scripts function. I also did more commits to the install script after making the video, but everything worked anyway as these were mainly stylistic changes or changes to echoes. Test performed on Ubuntu Server 22.04.2 VM in Proxmox VE on a Dell Poweredge R720xd running a fresh install of Swizzin. Only other packages installed on Swizzin were panel and nginx.

If you want to watch the test video in 1080p:
https://youtu.be/Swa9ESljrVU

Uploaded in 480p to meet GitHub size limits:
https://github.com/swizzin/swizzin/assets/51092829/d0f279c7-0c6d-41a6-8207-c5c5addf1726

Architectures

	`amd64`	`arm64`	Unspecified
Jammy	✅
Focal
Bookworm
Bullseye
Buster
Raspbian	⚫️	⚫️	⚫️

✅❎ Passed

🛠🛠 TODO

❌❌ Currently failing

Jellyfin split their repository into seperate ones for Debian and Ubuntu. These changes will make Swizzin compliant.

I accidentally typed "key" rather than "repository" here in my last commit and didn't notice.

Jellyfin is completely switched to the new repositories. They split Debian and Ubuntu apart. Swizzin should be compliant now.

These variables were not used at all in these scripts.

Update and install should have progress echos.

Made some of the echos more pretty and fitting with the rest of Swizzin.

…nges are made. Tried installing on amd64 using previous iteration. Failed due to not supporting amd64 even though it is supported.

Previously removed BASE_OS while fixing another bug, accidentally created this one.

Script catches a warning when trying to perform dist_info.

…versions Jellyfin supports and it causes a bug anyway. Since Swizzin is less compatible than Jellyfin, checking for compatability is redundant. Code removed due to causing program-exiting bugs.

Optimizing key pulling and installation.

…ion of download program selector. I forgot to include a path for curl and wget.

Previous implementation resulted in key not being grabbed successfully. Works way better if you just assume curl is present.

These echoes are not needed for the script to function as intended.

…gning key. I think it looks nicer now.

Unnecessary echo before adding signing key.

Fixing the issues with architecture and distribution filtering that caused issues in the install script. Also made some changes to create better parity between the scripts.

Shellcheck was complaining so trying an experimental fix. Hope this works.

Gets rid of some unreadable code in favor of something that does basically the same thing.

These echoes should fit the overall theme better now.

Jellyfin key used previously has expired. This will automatically pull the new key from Jellyfin.

liaralabs

Thanks for the PR KatieTheDev. There are a few issues that cropped up during the review that should be resolved, but this otherwise looks good.

Thanks for the contribution!

scripts/install/jellyfin.sh

liaralabs · 2023-07-08T17:21:51Z

scripts/install/jellyfin.sh

+
+# Handle some known alternative base OS values with 1-to-1 mappings
+# Use the result as the repository base OS
+case "${BASE_OS}" in


This case is basically useless aside from setting the _os_codename. If an OS doesn't directly identify itself as Debian or Ubuntu (i.e. during install) then we don't support it.

We certainly don't support linux mint or kde neon

I was unaware we don’t support those distros at all. I will be removing them from the scripts.

I removed unsupported distros, but I am not aware if _os_codename is set as debian on raspbian. It is necessary to make sure raspbian is set to the same repos as debian, as that is what Jellyfin requires.

scripts/install/jellyfin.sh

scripts/update/jellyfin.sh

liaralabs · 2023-07-08T17:27:24Z

scripts/update/jellyfin.sh

+ # Use the result as the repository base OS
+ ARCHITECTURE="$(dpkg --print-architecture)"
+ BASE_OS="$(awk -F'=' '/^ID=/{ print $NF }' /etc/os-release)"
+ case "${BASE_OS}" in


replicated code should be a function; however, this is useless code beyond the setting of the distro codename (as above)

I will use _os_codename in both cases if you can confirm that raspbian is set to debian. If not, I will create a function.

liaralabs · 2023-07-08T17:29:07Z

scripts/update/jellyfin.sh

+
+ #
+ # Install the Deb822 format jellyfin.sources entry
+ echo_progress_start "Adding Jellyfin repository to apt"


Replicated code should be functionized (sources/functions/jellyfin), however I wouldn't block merging based on this, but it would be best-practices for long-term ease of maintenace.

KatieTheDev · 2023-07-08T19:05:48Z

I will make the desired changes. Also, I realized that universe was redundant at some point in revising before I submitted the PR, but I must’ve forgotten to either fix that or commit the fix. I also didn’t know about the builtins you mentioned. Also, the reason I disabled force https is because I believe it breaks app support. I will try again with it enabled and see if there’s another workaround for that bug. Something is causing the app not to see the server in the default configuration. I think it may be binding to 127.0.0.1 when nginx is enabled which is blocking outside connections and the apps don’t really like going through nginx. I’ll spend some time on this when I can.

flying-sausages · 2023-07-16T16:22:44Z

Also, the reason I disabled force https is because I believe it breaks app support. I will try again with it enabled and see if there’s another workaround for that bug. Something is causing the app not to see the server in the default configuration. I think it may be binding to 127.0.0.1 when nginx is enabled which is blocking outside connections and the apps don’t really like going through nginx. I’ll spend some time on this when I can.

like mobile apps? If that were the case we would have had a lot more people complain about that by now I think

liaralabs · 2023-07-16T16:24:18Z

I do think some of the mobile apps won't work with self-signed certificates. The use-case of this self-signed cert is limited only to installs without the nginx proxy though, so the amount of people using self-signed certs on installs without nginx is probably limited. That said, it would also affect folks without a domain/let's encrypt

KatieTheDev · 2023-07-16T16:27:38Z

Would it be acceptable for me to add instructions for turning it off in the wiki as a potential fix for app issues?

flying-sausages · 2023-07-16T16:29:02Z

Would it be acceptable for me to add instructions for turning it off in the wiki as a potential fix for app issues?

That, plus maybe a echo_docs in the code for when you can see it might be relevant to the users maybe, but not a required addition from my end

KatieTheDev · 2023-07-18T23:07:07Z

I don't really know how to fix the conflicts that need to be resolved.

Trying to make the echoes more descriptive.

Universe repo is Ubuntu-only. Removed.

KatieTheDev · 2023-07-18T23:29:47Z

I believe that I have resolved merge conflicts and I have merged the latest updates into my branch. I believe I have also resolved the blocking changes, as I have switched everything to builtins that I noticed in your suggestions. I will now work on functionizing things.

KatieTheDev · 2023-07-18T23:33:52Z

I am unsure why pre-commit is showing a failure. I have no errors in shellcheck.

See PR 1032 for more info.

KatieTheDev · 2023-07-18T23:44:42Z

I added a new commit splitting the repository into a separate function. I was also able to include those new variables into it, as the only place those were used was in that function.

liaralabs · 2023-08-02T02:10:08Z

scripts/install/jellyfin.sh

@@ -40,6 +34,17 @@ if [[ -n $active ]]; then
 fi
 fi

+#
+## Get the path to gpg or install it
+GNUPG=$(which gpg)


gnupg2 is a global dependency of swizzin. You can safely assume every user has this installed already.

liaralabs · 2023-08-02T02:13:39Z

sources/functions/jellyfin

+ ARCHITECTURE="$(_os_arch)"
+ BASE_OS="$(_os_distro)"
+ case "${BASE_OS}" in
+ raspbian)


I don't think raspbian will pass this check so we don't need to write a case for it

liaralabs · 2023-08-02T02:15:09Z

LGTM other than the two comments

liaralabs · 2023-08-02T02:17:25Z

I am unsure why pre-commit is showing a failure. I have no errors in shellcheck.

I believe the errors were a result of sausage doing the dev work on pre-commit checks at the same time and the pipeline issues have been resolved. Next time you commit it should re-check 🤞

KatieTheDev added 21 commits July 3, 2023 17:10

fix(apt): 🚧 Switch Jellyfin over to the new official repositories.

1d7b4da

Jellyfin split their repository into seperate ones for Debian and Ubuntu. These changes will make Swizzin compliant.

style(apt): 🚧 Fix typo in a comment explaining something

a3e7477

I accidentally typed "key" rather than "repository" here in my last commit and didn't notice.

fix(apt): 📦 Switch Jellyfin to the new repositories.

1d3e3f2

Jellyfin is completely switched to the new repositories. They split Debian and Ubuntu apart. Swizzin should be compliant now.

style(shellcheck): 🔥 Remove unnecessary variables

bbe6273

These variables were not used at all in these scripts.

style(echos): 🎨 Added some echos to better describe what is happening.

cacdb90

Update and install should have progress echos.

style(echos): 🎨 Echo improvements

a0a231c

Made some of the echos more pretty and fitting with the rest of Swizzin.

fix: 🐛 Checking architecture errors out install script before any cha…

43b7a57

…nges are made. Tried installing on amd64 using previous iteration. Failed due to not supporting amd64 even though it is supported.

fix: 🐛 BASE_OS must be present in order to get the right repository

fade94a

Previously removed BASE_OS while fixing another bug, accidentally created this one.

fix: 🐛 dist_info not found, removed.

94ddc93

Script catches a warning when trying to perform dist_info.

fix: 🐛 Version checking is redundant as swizzin is only supported by …

1ecbff5

…versions Jellyfin supports and it causes a bug anyway. Since Swizzin is less compatible than Jellyfin, checking for compatability is redundant. Code removed due to causing program-exiting bugs.

fix(setup): 🐛 Added a way to fetch and install signing key

870fc5f

Optimizing key pulling and installation.

fix: 🐛 Script failing to get signing keys due to improper implementat…

cc216ec

…ion of download program selector. I forgot to include a path for curl and wget.

fix: 🐛 Use curl -fsSL to get key. Previous implementation causing bugs.

89a5568

Previous implementation resulted in key not being grabbed successfully. Works way better if you just assume curl is present.

style: 🔥 Remove unnecessary echoes

799c871

These echoes are not needed for the script to function as intended.

style: 🎨 Changed verbiage of some echoes and changed echo type for si…

41d641e

…gning key. I think it looks nicer now.

style(echos): 🎨 Further improvements to echoes.

6f83dd6

Unnecessary echo before adding signing key.

fix: 🐛 Fixing same issue that I found in the install script.

bdf19c9

Fixing the issues with architecture and distribution filtering that caused issues in the install script. Also made some changes to create better parity between the scripts.

fix(shellcheck): 🎨 Shellcheck was complaining about this

2404dae

Shellcheck was complaining so trying an experimental fix. Hope this works.

refactor: 🎨 More elegant way of disabling and removing services.

2678a36

Gets rid of some unreadable code in favor of something that does basically the same thing.

style(echos): 🎨 Making some echoes look nice

b70e6e8

These echoes should fit the overall theme better now.

feat: ✨ Automatically update the Jellyfin key

4d83319

Jellyfin key used previously has expired. This will automatically pull the new key from Jellyfin.

liaralabs requested changes Jul 8, 2023

View reviewed changes

github-actions bot added the has conflicts This PR has conflicts against master label Jul 16, 2023

fix: Trying to fix merge conflict

1b2839e

KatieTheDev and others added 6 commits July 18, 2023 17:10

Merge branch 'swizzin:develop' into develop

fb90ac2

style(echos): 🎨 Modify echoes

7f73a11

Trying to make the echoes more descriptive.

style(apt): 🎨 Remove unsupported distros from switching.

2b25b27

style: 🎨 Use some more builtins

de9d67b

fix: 🎨 Remove Ubuntu-centric "universe" repo

4be6eee

Universe repo is Ubuntu-only. Removed.

style: 🎨 Use more builtins

f746309

style: 🎨 Move repo-adding to a seperate function as it is replicated.

83b0a17

See PR 1032 for more info.

github-actions bot removed the has conflicts This PR has conflicts against master label Jul 20, 2023

liaralabs reviewed Aug 2, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix Jellyfin not installing correctly #1032

Fix Jellyfin not installing correctly #1032

KatieTheDev commented Jul 4, 2023

liaralabs left a comment

liaralabs Jul 8, 2023

KatieTheDev Jul 8, 2023

KatieTheDev Jul 18, 2023

liaralabs Jul 8, 2023

KatieTheDev Jul 18, 2023

liaralabs Jul 8, 2023

KatieTheDev commented Jul 8, 2023

flying-sausages commented Jul 16, 2023

liaralabs commented Jul 16, 2023

KatieTheDev commented Jul 16, 2023

flying-sausages commented Jul 16, 2023

KatieTheDev commented Jul 18, 2023

KatieTheDev commented Jul 18, 2023

KatieTheDev commented Jul 18, 2023

KatieTheDev commented Jul 18, 2023

liaralabs Aug 2, 2023

liaralabs Aug 2, 2023

liaralabs commented Aug 2, 2023

liaralabs commented Aug 2, 2023

Fix Jellyfin not installing correctly #1032

Are you sure you want to change the base?

Fix Jellyfin not installing correctly #1032

Conversation

KatieTheDev commented Jul 4, 2023

Description

Fixes issues:

Proposed Changes:

Change Categories

Checklist

Test scenarios

Architectures

✅❎ Passed

🛠🛠 TODO

❌❌ Currently failing

liaralabs left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

KatieTheDev commented Jul 8, 2023

flying-sausages commented Jul 16, 2023

liaralabs commented Jul 16, 2023

KatieTheDev commented Jul 16, 2023

flying-sausages commented Jul 16, 2023

KatieTheDev commented Jul 18, 2023

KatieTheDev commented Jul 18, 2023

KatieTheDev commented Jul 18, 2023

KatieTheDev commented Jul 18, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

liaralabs commented Aug 2, 2023

liaralabs commented Aug 2, 2023