rTorrent: Network configuration suggestion #1016
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit suggests implementation of a 4MB send and receive buffer for TCP sockets to improve throughput on gigabit connections. It explains why they are disabled by default on rTorrent and how much memory is consumed. It also adds a missing configuration variable for per torrent upload slots. The default value of 50 is applied.
liaralabs
requested changes
May 24, 2023
| throttle.max_uploads.global.set = 100 | ||
| throttle.min_peers.normal.set = 1 | ||
| throttle.min_peers.seed.set = -1 | ||
| trackers.use_udp.set = yes | ||
|
|
||
| # Disabled by default becuase these will override Linux Kernel settings | ||
| # Suggested to configure on a per application basis to improve throughput |
There was a problem hiding this comment.
Remove 43-46 and link to documentation instead.
Also this is not my suggestion nor the opinion of other maintainers as many users have server oriented kernel configs installed during their setup.
I would allow wording closer to "you may wish to configure..." In the docs article that will be linked to, so as to not potentially confuse users into thinking they blindingly need to apply configs they may not understand but could potentially override other pre-configured defaults as shipped by their provider.
|
This pull request is marked a draft for now. I will return it when time permits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit suggests implementation of a 4MB send and receive buffer for TCP sockets to improve throughput on gigabit connections. It explains why they are disabled by default on rTorrent and how much memory is consumed.
It also adds a missing configuration variable for per torrent upload slots. The default value of 50 is applied.