Ensure TS compiler option to SWC config transformer respects inline source map option #726
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the
swc-node/register
package does not respect theinlineSourceMap
option fromtsconfig
. WheninlineSourceMap
is set totrue
,swc/register
does not generate inline source maps. The issue is within thetsCompilerOptionsToSwcConfig
function, where it only setssourcemap
property on the return object totrue
if the TS configsourceMap
property istrue
, regardless of theinlineSourceMap
property.Also, per TS Config documentation (https://www.typescriptlang.org/tsconfig#inlineSourceMap),
inlineSourceMap
andsourcemap
are mutually exclusive, therefore, both cannot be set totrue
.This PR addresses this issue by checking for both of these TS config properties separately.