Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue 1601 #1624

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix for issue 1601 #1624

wants to merge 3 commits into from

Conversation

ymohdriz
Copy link
Contributor

@ymohdriz ymohdriz commented Nov 2, 2021

Hi team,

This PR is to solve issue #1601 (Parser does not validate GET request with request body)
Please review the PR and merge the same.

Thanks,
Mohammed Rizwan

Parser does not validate GET request with request body
Copy link
Contributor

@gracekarina gracekarina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @ymohdriz thanks for this PR, but sadly I cannot merged as is, because it will introduce a breaking change for those who use parser and do not expect that message validation. I will keep this in the radar for when we implement a different message handler, so when something is a warning won't break the validation of parser.

@ymohdriz
Copy link
Contributor Author

ymohdriz commented Nov 3, 2021

Hi @gracekarina,

Make sense.
What if we can add this warning only if it's OAI version >= 3.0.3 so that it won't affect the backward compatibility. Your thoughts, please?

Thanks,
Mohammed Rizwan

@gracekarina
Copy link
Contributor

Hi @gracekarina,

Make sense. What if we can add this warning only if it's OAI version >= 3.0.3 so that it won't affect the backward compatibility. Your thoughts, please?

Thanks, Mohammed Rizwan

Let's wait until we do some improvements at the way parser warns it will be a full change. thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants