Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bind:group #11256

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

fix bind:group #11256

wants to merge 3 commits into from

Conversation

iacore
Copy link

@iacore iacore commented Apr 20, 2024

Hopefully fixes #2308

repo i used to test this fix: https://github.com/iacore/fix-svelte-bind-group

the code using new Set() feels inefficient though. it might be better to make value in bind:group=value a Set.

Copy link

changeset-bot bot commented Apr 20, 2024

⚠️ No Changeset found

Latest commit: 26e9636

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Rich-Harris
Copy link
Member

It looks like this breaks a bunch of tests. It's not totally clear what's going on here — if you're still interested in working on this, mind adding a test that fails without this change?

Marking as draft in the meantime

@Rich-Harris Rich-Harris marked this pull request as draft May 15, 2024 21:11
@iacore iacore mentioned this pull request May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bind:group does not work with nested components
2 participants