Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for submitting this pull request! We really appreciate you spending the time to work on these changes.
What is the motivation?
To start fuzzing the new parser to identify any issues with it before it becomes the default. The old parser has been fuzzed in OSS-Fuzz for a year and no new issues have been identified for months. Since no significant changes are planned on the old parser, it makes sense to start fuzzing the new one in OSS-Fuzz instead. Fuzzing the old parser is still possible in branch
1.x
.What does this change do?
Enables the
parser2
feature in the fuzzing build so that the new experimental parser is used. Enforces that the fuzzer check passes and updates the README file with current information. The fuzzer check will fail until google/oss-fuzz#11777 is merged. After the new parser is the default inmain
, theparser2
feature can be dropped fromCargo.toml
.What is your testing strategy?
Tested the build locally on the google/oss-fuzz#11777 branch. Ensure that the fuzzer check passes in CI.
Is this related to any issues?
No.
Does this change need documentation?
Have you read the Contributing Guidelines?